Skip to content

Commit 70ebd9a

Browse files
fix: run playwright install and adjust date locator (#4365)
1 parent 7798241 commit 70ebd9a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

advanced-api/dynamic-remotes-synchronous-imports/e2e/checkDynamicRemotesSynchImportApps.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ async function waitForDynamicImport(page: Page, timeout: number = 5000) {
3838

3939
async function checkDateFormat(page: Page) {
4040
// Check for moment.js date display - just look for the Live Time text which indicates moment.js is working
41-
const dateElement = page.locator('text=Live Time (via shared moment.js):');
41+
const dateElement = page.locator('text=Live Time (via shared moment.js):').first();
4242
await dateElement.waitFor({ timeout: 5000 });
4343
}
4444

advanced-api/dynamic-remotes-synchronous-imports/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
"build": "pnpm --filter dynamic-remotes-synchronous-imports_app* --parallel build",
1212
"serve": "pnpm --filter dynamic-remotes-synchronous-imports_app* --parallel serve",
1313
"clean": "pnpm --filter dynamic-remotes-synchronous-imports_app* --parallel clean",
14-
"e2e:ci": "npx playwright test",
15-
"legacy:e2e:ci": "npx playwright test"
14+
"e2e:ci": "pnpm exec playwright install --with-deps && pnpm exec playwright test",
15+
"legacy:e2e:ci": "pnpm exec playwright install --with-deps && pnpm exec playwright test"
1616
},
1717
"devDependencies": {
1818
"@playwright/test": "^1.54.2",

0 commit comments

Comments
 (0)