fix: improve CI caching strategy to avoid pnpm hard link errors

- Cache only pnpm store directory instead of node_modules
- Separate caches for pnpm store, Cypress binary, and Playwright browsers
- Fix hard link errors by letting pnpm recreate node_modules from cached store
- Update both pull request and push workflows with consistent caching
- Remove unused env variables CACHE_PATH and YARN_CACHE_PATH
- Add conditional installation for Cypress and Playwright based on cache hits

This resolves the '/node_modules/.bin: Cannot hard link' errors and improves
CI performance by reducing cache size and avoiding symlink issues.

Author: ScriptedAlchemy

.github/workflows/on-pull-request.yml

@@ -6,11 +6,6 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  CACHE_PATH: |
-    **/node_modules
-    ~/.cache/Cypress
-  YARN_CACHE_PATH: |
-    ~/.pnpm-store
   FILES_TO_DELETE: |
     sudo rm -rf "/usr/share/dotnet"
     sudo rm -rf "/usr/share/swift"
@@ -130,14 +125,26 @@ jobs:
       - name: Setup pnpm cache
         uses: actions/cache@v4
         with:
-          path: |
-            ${{ steps.pnpm-cache.outputs.STORE_PATH }}
-            **/node_modules
-            ~/.cache/Cypress
-            ~/.cache/ms-playwright
-          key: deps-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
+          path: ${{ steps.pnpm-cache.outputs.STORE_PATH }}
+          key: pnpm-store-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
           restore-keys: |
-            deps-${{ runner.os }}-
+            pnpm-store-${{ runner.os }}-
+
+      - name: Cache Cypress binary
+        uses: actions/cache@v4
+        with:
+          path: ~/.cache/Cypress
+          key: cypress-${{ runner.os }}-cypress-13.12.0
+          restore-keys: |
+            cypress-${{ runner.os }}-
+
+      - name: Cache Playwright browsers
+        uses: actions/cache@v4
+        with:
+          path: ~/.cache/ms-playwright
+          key: playwright-${{ runner.os }}-1.54.2
+          restore-keys: |
+            playwright-${{ runner.os }}-
 
       - name: Install dependencies
         run: |
@@ -191,37 +198,70 @@ jobs:
         run: |
           echo "STORE_PATH=$(pnpm store path)" >> $GITHUB_OUTPUT
 
-      - name: Restore dependency cache
+      - name: Restore pnpm cache
         uses: actions/cache/restore@v4
-        id: deps-cache
-        with:
-          path: |
-            ${{ steps.pnpm-cache.outputs.STORE_PATH }}
-            **/node_modules
-            ~/.cache/Cypress
-            ~/.cache/ms-playwright
-          key: deps-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
+        id: pnpm-store-cache
+        with:
+          path: ${{ steps.pnpm-cache.outputs.STORE_PATH }}
+          key: pnpm-store-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
           restore-keys: |
-            deps-${{ runner.os }}-
+            pnpm-store-${{ runner.os }}-
           fail-on-cache-miss: false
 
-      - name: Install deps if cache miss
+      - name: Restore Cypress cache
+        uses: actions/cache/restore@v4
+        id: cypress-cache
+        with:
+          path: ~/.cache/Cypress
+          key: cypress-${{ runner.os }}-cypress-13.12.0
+          restore-keys: |
+            cypress-${{ runner.os }}-
+          fail-on-cache-miss: false
+
+      - name: Restore Playwright cache
+        if: matrix.container == 'bi-directional'
+        uses: actions/cache/restore@v4
+        id: playwright-cache
+        with:
+          path: ~/.cache/ms-playwright
+          key: playwright-${{ runner.os }}-1.54.2
+          restore-keys: |
+            playwright-${{ runner.os }}-
+          fail-on-cache-miss: false
+
+      - name: Install dependencies
         id: install-deps-e2e
-        if: steps.deps-cache.outputs.cache-hit != 'true'
         env:
           NODE_OPTIONS: '--max_old_space_size=6144'
           FORCE_COLOR: 3
         run: |
-          echo "Cache miss - this should not happen as deps were installed in setup-matrix job"
+          echo "Installing dependencies from cached pnpm store..."
           pnpm install --frozen-lockfile --prefer-offline
-          npx cypress verify
+          
+          # Verify Cypress if needed
+          if [ "${{ steps.cypress-cache.outputs.cache-hit }}" != "true" ]; then
+            echo "Installing Cypress binary..."
+            npx cypress install
+          else
+            echo "Cypress binary already cached"
+            npx cypress verify || true
+          fi
           
       - name: Install Playwright for projects that need it
         run: |
           if [ "${{ matrix.container }}" = "bi-directional" ]; then
-            echo "Installing Playwright for bi-directional example..."
+            echo "Setting up Playwright for bi-directional example..."
             cd ${{ matrix.container }}
-            npx playwright install --with-deps chromium
+            
+            # Check if Playwright browsers are already cached
+            if [ "${{ steps.playwright-cache.outputs.cache-hit }}" = "true" ] && [ -d "$HOME/.cache/ms-playwright" ]; then
+              echo "Playwright browsers already cached, installing system dependencies only..."
+              npx playwright install-deps chromium
+            else
+              echo "Installing Playwright browsers and dependencies..."
+              npx playwright install --with-deps chromium
+            fi
+            
             cd ..
           fi
 

.github/workflows/on-push.yml

@@ -9,10 +9,6 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  CACHE_PATH: |
-    **/node_modules
-    ~/.cache/Cypress
-    ~/.pnpm-store
   FILES_TO_DELETE: |
     sudo rm -rf "/usr/share/dotnet"
     sudo rm -rf "/usr/share/swift"
@@ -75,26 +71,47 @@ jobs:
           cache: 'pnpm'
           cache-dependency-path: '**/pnpm-lock.yaml'
 
-      - name: Enhanced caching with fallbacks
+      - name: Get pnpm store directory
+        id: pnpm-cache
+        shell: bash
+        run: |
+          echo "STORE_PATH=$(pnpm store path)" >> $GITHUB_OUTPUT
+
+      - name: Setup pnpm cache
+        uses: actions/cache@v4
+        id: pnpm-store-cache
+        with:
+          path: ${{ steps.pnpm-cache.outputs.STORE_PATH }}
+          key: pnpm-store-${{ runner.os }}-${{ steps.yarn-hash.outputs.yarnHash }}
+          restore-keys: |
+            pnpm-store-${{ runner.os }}-
+
+      - name: Cache Cypress binary
+        uses: actions/cache@v4
+        with:
+          path: ~/.cache/Cypress
+          key: cypress-${{ runner.os }}-cypress-13.12.0
+          restore-keys: |
+            cypress-${{ runner.os }}-
+
+      - name: Cache Playwright browsers
         uses: actions/cache@v4
-        id: yarn-cache
         with:
-          path: |
-            ~/.pnpm-store
-            **/node_modules
-            ~/.cache/Cypress
-            ~/.cache/ms-playwright
-          key: e2e-cache-${{ runner.os }}-${{ steps.yarn-hash.outputs.yarnHash }}
+          path: ~/.cache/ms-playwright
+          key: playwright-${{ runner.os }}-1.54.2
           restore-keys: |
-            e2e-cache-${{ runner.os }}-
-            e2e-cache-
+            playwright-${{ runner.os }}-
 
       - name: Install deps
-        if: steps.yarn-cache.outputs.cache-hit != 'true'
         env:
           NODE_OPTIONS: '--max_old_space_size=6144'
           FORCE_COLOR: 3
         run: |
-          echo "PNPM lockfile changed - installing dependencies..."
-          pnpm config set store-dir ~/.pnpm-store
+          echo "Installing dependencies from pnpm store..."
           pnpm install --frozen-lockfile --prefer-offline
+          
+          # Install Cypress binary if not cached
+          if [ -z "$(ls -A ~/.cache/Cypress 2>/dev/null)" ]; then
+            echo "Installing Cypress binary..."
+            npx cypress install
+          fi