Skip to content

Commit e7b0fb5

Browse files
fix: handle Playwright installation for specific projects only
Remove global Playwright installation that was causing "playwright: not found" errors. Instead, install Playwright only for projects that need it (like bi-directional) during the e2e test job. This fixes the setup-matrix job failure and ensures Playwright is only installed where it's actually used. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent c0eb925 commit e7b0fb5

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

.github/workflows/on-pull-request.yml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,6 @@ jobs:
144144
echo "Installing all dependencies to populate cache..."
145145
pnpm install --frozen-lockfile --prefer-offline
146146
npx cypress install
147-
npx playwright install --with-deps chromium
148147
149148
- name: Create matrix
150149
id: set-matrix
@@ -216,7 +215,15 @@ jobs:
216215
echo "Cache miss - this should not happen as deps were installed in setup-matrix job"
217216
pnpm install --frozen-lockfile --prefer-offline
218217
npx cypress verify
219-
npx playwright install --with-deps chromium
218+
219+
- name: Install Playwright for projects that need it
220+
run: |
221+
if [ "${{ matrix.container }}" = "bi-directional" ]; then
222+
echo "Installing Playwright for bi-directional example..."
223+
cd ${{ matrix.container }}
224+
npx playwright install --with-deps chromium
225+
cd ..
226+
fi
220227
221228
- name: Run sample webpack e2e tests
222229
timeout-minutes: 30

.github/workflows/on-push.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,4 +98,3 @@ jobs:
9898
echo "PNPM lockfile changed - installing dependencies..."
9999
pnpm config set store-dir ~/.pnpm-store
100100
pnpm install --frozen-lockfile --prefer-offline
101-
npx playwright install --with-deps chromium

0 commit comments

Comments
 (0)