Skip to content

feat: add ignoreOrigin option #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gioboa merged 2 commits into from
May 14, 2025
Merged

feat: add ignoreOrigin option #290

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f863ae2
Ignore Origin
lelemm Apr 21, 2025
27dd069
fixed unit test
lelemm Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/pluginProxyRemoteEntry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export default function (): Plugin {
? viteConfig.server.host
: 'localhost';
return `
const origin = window ? window.origin : "//${host}:${viteConfig.server?.port}"
const origin = (window && ${!options.ignoreOrigin}) ? window.origin : "//${host}:${viteConfig.server?.port}"
const remoteEntryPromise = await import(origin + "${viteConfig.base + options.filename}")
// __tla only serves as a hack for vite-plugin-top-level-await.
Promise.resolve(remoteEntryPromise)
Expand Down
3 changes: 3 additions & 0 deletions src/utils/normalizeModuleFederationOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ export type ModuleFederationOptions = {
dev?: boolean | PluginDevOptions;
dts?: boolean | PluginDtsOptions;
shareStrategy?: ShareStrategy;
ignoreOrigin?: boolean;
};

export interface NormalizedModuleFederationOptions {
Expand All @@ -296,6 +297,7 @@ export interface NormalizedModuleFederationOptions {
dts?: boolean | PluginDtsOptions;
shareStrategy: ShareStrategy;
getPublicPath?: string;
ignoreOrigin?: boolean;
}

interface PluginDevOptions {
Expand Down Expand Up @@ -371,5 +373,6 @@ export function normalizeModuleFederationOptions(
dts: options.dts,
getPublicPath: options.getPublicPath,
shareStrategy: options.shareStrategy || 'version-first',
ignoreOrigin: options.ignoreOrigin || false,
});
}
Loading