xPDORedisCache expire can't be zero (#261)

* Update xPDORedisCache.php

* Update formatting

---------

Co-authored-by: Jason Coward <[email protected]>

Author: Bournwog

src/xPDO/Cache/xPDORedisCache.php

@@ -7,7 +7,9 @@
  * For the full copyright and license information, please view the LICENSE
  * file that was distributed with this source code.
  */
+
 namespace xPDO\Cache;
+
 use xPDO\xPDO;
 use Redis;
 
@@ -18,74 +20,99 @@
  *
  * @package xPDO\Cache
  */
-class xPDORedisCache extends xPDOCache {
+class xPDORedisCache extends xPDOCache
+{
     protected $redis = null;
 
-    public function __construct(& $xpdo, $options = array()) {
-        parent :: __construct($xpdo, $options);
+    public function __construct(&$xpdo, $options = [])
+    {
+        parent:: __construct($xpdo, $options);
         if (class_exists('Redis', true)) {
-            $this->redis= new Redis();
+            $this->redis = new Redis();
             if ($this->redis) {
-                $server = explode(':', $this->getOption($this->key . '_redis_server', $options, $this->getOption('redis_server', $options, 'localhost:6379')));                
-                if($this->redis->pconnect($server[0], (integer) $server[1])){                    
-                    $redis_auth=$this->getOption('redis_auth', $options, '');
-                    if(!empty($redis_auth)){
-                        $this->redis->auth($redis_auth);    
+                $server = explode(
+                    ':',
+                    $this->getOption(
+                        $this->key . '_redis_server',
+                        $options,
+                        $this->getOption('redis_server', $options, 'localhost:6379')
+                    )
+                );
+                if ($this->redis->pconnect($server[0], (integer)$server[1])) {
+                    $redis_auth = $this->getOption('redis_auth', $options, '');
+                    if (!empty($redis_auth)) {
+                        $this->redis->auth($redis_auth);
                     }
                     $this->redis->select((integer)$this->getOption('redis_db', $options, 0));
                     $this->redis->setOption(Redis::OPT_SERIALIZER, Redis::SERIALIZER_PHP);
-                    $this->initialized = true;                        
-                }   
+                    $this->initialized = true;
+                }
             } else {
                 $this->redis = null;
-                $this->xpdo->log(xPDO::LOG_LEVEL_ERROR, "xPDORedisCache[{$this->key}]: Error creating redis provider for server(s): " . $this->getOption($this->key . '_redisd_server', $options, $this->getOption('redisd_server', $options, 'localhost:6379')));
+                $this->xpdo->log(
+                    xPDO::LOG_LEVEL_ERROR,
+                    "xPDORedisCache[{$this->key}]: Error creating redis provider for server(s): " . $this->getOption(
+                        $this->key . '_redisd_server',
+                        $options,
+                        $this->getOption('redisd_server', $options, 'localhost:6379')
+                    )
+                );
             }
         } else {
-            $this->xpdo->log(xPDO::LOG_LEVEL_ERROR, "xPDORedisCache[{$this->key}]: Error creating redis provider; xPDORedisCache requires the PHP redis extension.");
+            $this->xpdo->log(
+                xPDO::LOG_LEVEL_ERROR,
+                "xPDORedisCache[{$this->key}]: Error creating redis provider; xPDORedisCache requires the PHP redis extension."
+            );
         }
     }
 
-    public function add($key, $var, $expire= 0, $options= array()) {
-        $added= false;
-        if(!$this->redis->exists($this->getCacheKey($key))){          
-            $added=$this->redis->set($this->getCacheKey($key),$var,$expire); 
+    public function add($key, $var, $expire = 0, $options = [])
+    {
+        $added = false;
+        if (!$this->redis->exists($this->getCacheKey($key))) {
+            $added = $this->set($key, $var, $expire);
         }
         return $added;
     }
 
-    public function set($key, $var, $expire= 0, $options= array()) {
+    public function set($key, $var, $expire = 0, $options = [])
+    {
         if ($expire === 0) {
-            $set = $this->redis->set($this->getCacheKey($key),$var); 
+            $set = $this->redis->set($this->getCacheKey($key), $var);
         } else {
-            $set = $this->redis->set($this->getCacheKey($key),$var,$expire); 
+            $set = $this->redis->set($this->getCacheKey($key), $var, $expire);
         }
         return $set;
     }
 
-    public function replace($key, $var, $expire= 0, $options= array()) {
-        $replaced=false;
-        if($this->redis->exists($this->getCacheKey($key))){          
-            $replaced=$this->redis->set($this->getCacheKey($key),$var,$expire); 
+    public function replace($key, $var, $expire = 0, $options = [])
+    {
+        $replaced = false;
+        if ($this->redis->exists($this->getCacheKey($key))) {
+            $replaced = $this->set($key, $var, $expire);
         }
         return $replaced;
     }
 
-    public function delete($key, $options= array()) {
+    public function delete($key, $options = [])
+    {
         if ($this->getOption(xPDO::OPT_CACHE_MULTIPLE_OBJECT_DELETE, $options, false)) {
-            $deleted= $this->flush($options);
+            $deleted = $this->flush($options);
         } else {
-            $deleted= $this->redis->delete($this->getCacheKey($key));
+            $deleted = $this->redis->delete($this->getCacheKey($key));
         }
 
         return $deleted;
     }
 
-    public function get($key, $options= array()) {
-        $value= $this->redis->get($this->getCacheKey($key));
+    public function get($key, $options = [])
+    {
+        $value = $this->redis->get($this->getCacheKey($key));
         return $value;
     }
 
-    public function flush($options= array()) {
+    public function flush($options = [])
+    {
         return $this->redis->flushDb();
     }
 }