Skip to content

Commit 806fed2

Browse files
committed
MakeMaker::Test::Setup::XS strict+warnings
1 parent 9dbdc84 commit 806fed2

File tree

1 file changed

+18
-6
lines changed
  • t/lib/MakeMaker/Test/Setup

1 file changed

+18
-6
lines changed

t/lib/MakeMaker/Test/Setup/XS.pm

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,14 @@ $typemap =~ s/ //g unless $MM->can_dep_space;
2525
chdir File::Spec->updir;
2626

2727
my $PM_TEST = <<'END';
28+
use strict;
29+
use warnings;
2830
package XS::Test;
2931
require Exporter;
3032
require DynaLoader;
31-
$VERSION = 1.01;
32-
@ISA = qw(Exporter DynaLoader);
33-
@EXPORT = qw(is_even);
33+
our $VERSION = 1.01;
34+
our @ISA = qw(Exporter DynaLoader);
35+
our @EXPORT = qw(is_even);
3436
bootstrap XS::Test $VERSION;
3537
1;
3638
END
@@ -52,13 +54,17 @@ END
5254

5355
my $T_TEST = <<'END';
5456
#!/usr/bin/perl -w
57+
use strict;
58+
use warnings;
5559
use Test::More tests => 3;
5660
use_ok "XS::Test";
5761
ok !is_even(1);
5862
ok is_even(2);
5963
END
6064

6165
my $MAKEFILEPL = <<'END';
66+
use strict;
67+
use warnings;
6268
use ExtUtils::MakeMaker;
6369
WriteMakefile(
6470
NAME => 'XS::%s',
@@ -72,6 +78,8 @@ END
7278
my $BS_TEST = '$DynaLoader::bscode = q(warn "BIG NOISE";)';
7379

7480
my $T_BOOTSTRAP = <<'EOF';
81+
use strict;
82+
use warnings;
7583
use Test::More tests => 1;
7684
my $w = '';
7785
$SIG{__WARN__} = sub { $w .= join '', @_; };
@@ -80,12 +88,14 @@ like $w, qr/NOISE/;
8088
EOF
8189

8290
my $PM_OTHER = <<'END';
91+
use strict;
92+
use warnings;
8393
package XS::Other;
8494
require Exporter;
8595
require DynaLoader;
86-
$VERSION = 1.20;
87-
@ISA = qw(Exporter DynaLoader);
88-
@EXPORT = qw(is_odd);
96+
our $VERSION = 1.20;
97+
our @ISA = qw(Exporter DynaLoader);
98+
our @EXPORT = qw(is_odd);
8999
bootstrap XS::Other $VERSION;
90100
1;
91101
END
@@ -107,6 +117,8 @@ END
107117

108118
my $T_OTHER = <<'END';
109119
#!/usr/bin/perl -w
120+
use strict;
121+
use warnings;
110122
use Test::More tests => 3;
111123
use_ok "XS::Other";
112124
ok is_odd(1);

0 commit comments

Comments
 (0)