Merge pull request #2 from hayanmind/feature/on-stop-for-props-start

ghsdh3409 · web-flow · commit dc53af485b60 · 2018-08-13T14:02:34.000+09:00
Fix a critical bug in lifecycle method
diff --git a/src/components/CopilotModal.js b/src/components/CopilotModal.js
@@ -61,7 +61,7 @@ class CopilotModal extends Component<Props, State> {
   };
 
   componentWillReceiveProps(nextProps: Props) {
-    if (nextProps.visible === false) {
+    if (this.props.visible === true && nextProps.visible === false) {
       this.reset();
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ class CopilotModal extends Component<Props, State> {`
`61`	`61`	`};`
`62`	`62`
`63`	`63`	`componentWillReceiveProps(nextProps: Props) {`
`64`		`- if (nextProps.visible === false) {`
	`64`	`+ if (this.props.visible === true && nextProps.visible === false) {`
`65`	`65`	`this.reset();`
`66`	`66`	`}`
`67`	`67`	`}`