Skip to content

Commit 83890d6

Browse files
[Sentinel One] - Fix Cannot execute ILM policy delete step (elastic#133793)
This PR focuses on the short term solution which add the logs-sentinel_one.application-* and logs-sentinel_one.application_risk-* indices under the kibana_system role with deletion privileges to prevent a failed deletion error when the index enters the deletion phase for the ILM lifecycle, in upcoming PR. As it ships transform pipeline too hence read, write permissions are also required. Current behavior: It shows permission issue while deleting the index. (cherry picked from commit bfde47a)
1 parent 1ba128b commit 83890d6

File tree

3 files changed

+16
-6
lines changed

3 files changed

+16
-6
lines changed

docs/changelog/133793.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
pr: 133793
2+
summary: "[Sentinel One] Add `manage`, `create_index`, `read`, `index`, `write`, `delete`, permission for third party agent indices `kibana_system`"
3+
area: Authorization
4+
type: enhancement
5+
issues:
6+
- 133703

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/store/KibanaOwnedReservedRoleDescriptors.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -487,7 +487,8 @@ static RoleDescriptor kibanaSystem(String name) {
487487
.indices(
488488
"logs-m365_defender.vulnerability-*",
489489
"logs-microsoft_defender_endpoint.vulnerability-*",
490-
"logs-microsoft_defender_cloud.assessment-*"
490+
"logs-microsoft_defender_cloud.assessment-*",
491+
"logs-sentinel_one.application_risk-*"
491492
)
492493
.privileges(
493494
"read",
@@ -496,10 +497,11 @@ static RoleDescriptor kibanaSystem(String name) {
496497
TransportDeleteIndexAction.TYPE.name()
497498
)
498499
.build(),
499-
// For ExtraHop and QualysGAV specific actions. Kibana reads, writes and manages this index
500+
// For ExtraHop, QualysGAV, and SentinelOne Application Dataset specific actions. Kibana reads, writes and manages this
501+
// index
500502
// for configured ILM policies.
501503
RoleDescriptor.IndicesPrivileges.builder()
502-
.indices("logs-extrahop.investigation-*", "logs-qualys_gav.asset-*")
504+
.indices("logs-extrahop.investigation-*", "logs-qualys_gav.asset-*", "logs-sentinel_one.application-*")
503505
.privileges(
504506
"manage",
505507
"create_index",

x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStoreTests.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1685,7 +1685,8 @@ public void testKibanaSystemRole() {
16851685
Arrays.asList(
16861686
"logs-m365_defender.vulnerability-" + randomAlphaOfLength(randomIntBetween(0, 13)),
16871687
"logs-microsoft_defender_endpoint.vulnerability-" + randomAlphaOfLength(randomIntBetween(0, 13)),
1688-
"logs-microsoft_defender_cloud.assessment-" + randomAlphaOfLength(randomIntBetween(0, 13))
1688+
"logs-microsoft_defender_cloud.assessment-" + randomAlphaOfLength(randomIntBetween(0, 13)),
1689+
"logs-sentinel_one.application_risk-" + randomAlphaOfLength(randomIntBetween(0, 13))
16891690
).forEach(indexName -> {
16901691
final IndexAbstraction indexAbstraction = mockIndexAbstraction(indexName);
16911692
assertThat(kibanaRole.indices().allowedIndicesMatcher("indices:foo").test(indexAbstraction), is(false));
@@ -1879,11 +1880,12 @@ public void testKibanaSystemRole() {
18791880
assertThat(kibanaRole.indices().allowedIndicesMatcher(RolloverAction.NAME).test(indexAbstraction), is(true));
18801881
});
18811882

1882-
// Tests for third-party agent indices (ExtraHop, QualysGAV) that `kibana_system` has full management access to
1883+
// Tests for third-party agent indices (ExtraHop, QualysGAV, SentinelOne) that `kibana_system` has full management access to
18831884
// This includes read, write, create, delete, and all ILM-related management actions.
18841885
Arrays.asList(
18851886
"logs-extrahop.investigation-" + randomAlphaOfLength(randomIntBetween(1, 10)),
1886-
"logs-qualys_gav.asset-" + randomAlphaOfLength(randomIntBetween(1, 10))
1887+
"logs-qualys_gav.asset-" + randomAlphaOfLength(randomIntBetween(1, 10)),
1888+
"logs-sentinel_one.application-" + randomAlphaOfLength(randomIntBetween(1, 10))
18871889
).forEach((index_qualys_extra_hop) -> {
18881890
final IndexAbstraction indexAbstraction = mockIndexAbstraction(index_qualys_extra_hop);
18891891

0 commit comments

Comments
 (0)