Skip to content

Commit a0ce52d

Browse files
committed
add tests for nested tooltips
1 parent e3ead5f commit a0ce52d

File tree

8 files changed

+562
-374
lines changed

8 files changed

+562
-374
lines changed

.size-snapshot.json

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,25 @@
11
{
22
"dist/index.js": {
3-
"bundled": 7461,
4-
"minified": 7461,
5-
"gzipped": 2211
3+
"bundled": 7333,
4+
"minified": 7333,
5+
"gzipped": 2207
66
},
77
"lib/cjs/index.js": {
8-
"bundled": 14080,
9-
"minified": 7781,
10-
"gzipped": 2143
8+
"bundled": 13954,
9+
"minified": 7653,
10+
"gzipped": 2137
1111
},
1212
"lib/esm/index.js": {
13-
"bundled": 14028,
14-
"minified": 7748,
15-
"gzipped": 2136,
13+
"bundled": 13902,
14+
"minified": 7620,
15+
"gzipped": 2132,
1616
"treeshaked": {
1717
"rollup": {
18-
"code": 7187,
18+
"code": 7059,
1919
"import_statements": 331
2020
},
2121
"webpack": {
22-
"code": 8421
22+
"code": 8293
2323
}
2424
}
2525
}

.travis.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
language: node_js
21
dist: xenial
2+
language: node_js
33
node_js:
4-
- 'stable'
4+
- '--lts'
55
cache: yarn
66
branches:
77
except:
88
- gh-pages
99
script:
1010
- yarn lint
11-
- yarn test --coverage
11+
- yarn test --ci --coverage
1212
- yarn build
1313
- yarn docs:build && cp .docz/dist/index.html .docz/dist/404.html
1414
deploy:

docs/examples/BasicTooltipTrigger.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ const BasicTooltipTrigger = memo(({tooltip, children, hideArrow, ...props}) => (
1212
arrowRef,
1313
placement
1414
}) => (
15-
<span
15+
<div
1616
{...getTooltipProps({
1717
ref: tooltipRef,
1818
className: 'tooltip-container'
1919
})}
2020
>
2121
{!hideArrow && (
22-
<span
22+
<div
2323
{...getArrowProps({
2424
ref: arrowRef,
2525
'data-placement': placement,
@@ -28,7 +28,7 @@ const BasicTooltipTrigger = memo(({tooltip, children, hideArrow, ...props}) => (
2828
/>
2929
)}
3030
{tooltip}
31-
</span>
31+
</div>
3232
)}
3333
>
3434
{({getTriggerProps, triggerRef}) => (

package.json

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -45,30 +45,30 @@
4545
"author": "Mohsin Ul Haq <[email protected]>",
4646
"license": "MIT",
4747
"peerDependencies": {
48-
"react": "^16.6.3",
49-
"react-dom": "^16.6.3"
48+
"react": "^16.7.0",
49+
"react-dom": "^16.7.0"
5050
},
5151
"dependencies": {
5252
"@babel/runtime": "^7.2.0",
5353
"react-popper": "^1.3.2"
5454
},
5555
"devDependencies": {
56-
"@babel/cli": "^7.2.0",
56+
"@babel/cli": "^7.2.3",
5757
"@babel/core": "^7.2.2",
58-
"@babel/plugin-proposal-class-properties": "^7.2.1",
58+
"@babel/plugin-proposal-class-properties": "^7.2.3",
5959
"@babel/plugin-transform-runtime": "^7.2.0",
60-
"@babel/preset-env": "^7.2.0",
60+
"@babel/preset-env": "^7.2.3",
6161
"@babel/preset-react": "^7.0.0",
6262
"@types/jest": "^23.3.10",
63-
"@types/react": "^16.7.17",
63+
"@types/react": "^16.7.18",
6464
"@types/react-dom": "^16.0.11",
65-
"babel-core": "^7.0.0-bridge",
65+
"babel-core": "^7.0.0-bridge.0",
6666
"babel-eslint": "^10.0.1",
6767
"babel-jest": "^23.6.0",
6868
"babel-plugin-transform-react-remove-prop-types": "^0.4.21",
69-
"docz": "^0.13.2",
69+
"docz": "^0.13.5",
7070
"docz-plugin-css": "^0.11.0",
71-
"docz-theme-default": "^0.13.1",
71+
"docz-theme-default": "^0.13.5",
7272
"eslint": "^5.10.0",
7373
"eslint-config-prettier": "^3.3.0",
7474
"eslint-plugin-jest": "^22.1.2",
@@ -80,11 +80,11 @@
8080
"pre-commit": "^1.2.2",
8181
"prettier": "^1.15.3",
8282
"prop-types": "^15.6.2",
83-
"react": "^16.6.3",
84-
"react-dom": "^16.6.3",
85-
"react-testing-library": "^5.4.0",
83+
"react": "^16.7.0",
84+
"react-dom": "^16.7.0",
85+
"react-testing-library": "^5.4.2",
8686
"rimraf": "^2.6.2",
87-
"rollup": "^0.68.0",
87+
"rollup": "^0.68.1",
8888
"rollup-plugin-babel": "^4.1.0",
8989
"rollup-plugin-commonjs": "^9.2.0",
9090
"rollup-plugin-node-resolve": "^4.0.0",

src/Tooltip.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ export default class Tooltip extends Component {
8686
removeParentOutsideClickHandler,
8787
removeParentOutsideRightClickHandler
8888
} = this.props;
89-
document.addEventListener('click', this._handleOutsideClick);
90-
document.addEventListener('contextmenu', this._handleOutsideRightClick);
89+
this._addOutsideClickHandler();
90+
this._addOutsideRightClickHandler();
9191
removeParentOutsideClickHandler && removeParentOutsideClickHandler();
9292
removeParentOutsideRightClickHandler &&
9393
removeParentOutsideRightClickHandler();
@@ -103,11 +103,8 @@ export default class Tooltip extends Component {
103103
addParentOutsideClickHandler,
104104
addParentOutsideRightClickHandler
105105
} = this.props;
106-
document.removeEventListener('click', this._handleOutsideClick);
107-
document.removeEventListener(
108-
'contextmenu',
109-
this._handleOutsideRightClick
110-
);
106+
this._removeOutsideClickHandler();
107+
this._removeOutsideRightClickHandler();
111108
this._handleOutsideClick = undefined;
112109
this._handleOutsideRightClick = undefined;
113110
addParentOutsideClickHandler && addParentOutsideClickHandler();

0 commit comments

Comments
 (0)