[Improvement] - Ask for a full rebuild options inplace of edit.

[BlackstormFirst]

Hello,
There is currently an issue with font positioning in EBML headers when using mkvpropedit.

Depending on the viewing software, fonts outside the first cluster are inaccessible.

Is it possible to add an option to choose a complete rebuild with mkvmerge (which takes longer) instead of a simple edit (with mkvpropedit), with the option to choose a different output directory (to prevent the original file from being altered)?

This would ensure the files have the information in the correct order.

Thank you in advance.

[moi15moi]

I won't do it, but if someone add this option and create a PR, I will review it.

Edit:

There is currently an issue with font positioning in EBML headers when using mkvpropedit.

I just understand that you are referring to this issue: peerless2012/libass-android#19
Note that this is a bug and is not a normal behaviour. I accept that someone add this feature, but not because it would help libass-android to get the font. Only because it is a good idea to not edit the mkv.

[BlackstormFirst]

Hello, thanks for your quick answer.
Yes, it should help for a workaround to avoid the libass-android issue but not only.

Having the opportunity to properly rebuild the mkv (even if it take longer), is always welcomed.

Actually i have a workaround... i just using mkv merge inside my loop, just after the fontcollector to consolidate all previous edit.

ie:
...
fontcollector -ass-mkv --collect-draw-fonts -mkv "$fullpath"
&"$Path_to_MKVMERGE" -o "$dirpath\process\$filename" "$fullpath"

To have it, you can add a parameter/trigger to the program, add a condition to use mkvmerge inplace of the mkvpropedit.
I will try to take a look to the code directly... but I'm not very comfortable with GitHub...

Edit: I quickly check the code, not a big deal i think... if i have time i will add a def into mkvmerge.py to match the current merge_fonts_into_mkv into mkvpropedit.py and see where to call it.