Use variable name 'client' for test_client instances

Author: roland-ruedenauer

src/moin/apps/admin/_tests/test_admin.py

@@ -25,8 +25,8 @@
     ),
 )
 def test_admin(app, url_for_args, status, data):
-    with app.test_client() as c:
-        rv = c.get(url_for(**url_for_args))
+    with app.test_client() as client:
+        rv = client.get(url_for(**url_for_args))
         assert rv.status == status
         assert rv.headers["Content-Type"] == "text/html; charset=utf-8"
         for item in data:

src/moin/apps/feed/_tests/test_feed.py

@@ -13,8 +13,8 @@
 
 class TestFeeds:
     def test_global_atom(self, app):
-        with app.test_client() as c:
-            rv = c.get(url_for("feed.atom"))
+        with app.test_client() as client:
+            rv = client.get(url_for("feed.atom"))
             assert rv.status == "200 OK"
             assert rv.headers["Content-Type"] == "application/atom+xml"
             assert rv.data.startswith(b"<?xml")
@@ -24,17 +24,17 @@ def test_global_atom(self, app):
     def test_global_atom_with_an_item(self, app):
         basename = "Foo"
         update_item(basename, {COMMENT: "foo data for feed item"}, "")
-        with app.test_client() as c:
-            rv = c.get(url_for("feed.atom"))
+        with app.test_client() as client:
+            rv = client.get(url_for("feed.atom"))
             assert rv.status == "200 OK"
             assert rv.headers["Content-Type"] == "application/atom+xml"
             assert rv.data.startswith(b"<?xml")
             assert b"foo data for feed item" in rv.data
 
         # Test cache invalidation
         update_item(basename, {COMMENT: "checking if the cache invalidation works"}, "")
-        with app.test_client() as c:
-            rv = c.get(url_for("feed.atom"))
+        with app.test_client() as client:
+            rv = client.get(url_for("feed.atom"))
             assert rv.status == "200 OK"
             assert rv.headers["Content-Type"] == "application/atom+xml"
             assert rv.data.startswith(b"<?xml")

src/moin/apps/frontend/_tests/test_frontend.py

@@ -37,10 +37,10 @@ def _test_view(
         if params is None:
             params = {}
 
-        with self.app.test_client() as c:
+        with self.app.test_client() as client:
             for method in ["HEAD", "GET"]:
                 print("%s %s" % (method, url_for(viewname, **viewopts)))
-                rv = c.open(url_for(viewname, **viewopts), method=method, data=params)
+                rv = client.open(url_for(viewname, **viewopts), method=method, data=params)
                 rv_data = rv.data.decode()
                 assert rv.status == status
                 assert rv.headers["Content-Type"] in content_types
@@ -63,8 +63,8 @@ def _test_view_post(
         if form is None:
             form = {}
         print("POST %s" % url_for(viewname, **viewopts))
-        with self.app.test_client() as c:
-            rv = c.post(url_for(viewname, **viewopts), data=form)
+        with self.app.test_client() as client:
+            rv = client.post(url_for(viewname, **viewopts), data=form)
             rv_data = rv.data.decode()
             assert rv.status == status
             assert rv.headers["Content-Type"] in content_types

src/moin/apps/misc/_tests/test_misc.py

@@ -10,16 +10,16 @@
 
 class TestMisc:
     def test_global_sitemap(self, app):
-        with app.test_client() as c:
-            rv = c.get(url_for("misc.sitemap"))
+        with app.test_client() as client:
+            rv = client.get(url_for("misc.sitemap"))
             assert rv.status == "200 OK"
             assert rv.headers["Content-Type"] == "text/xml; charset=utf-8"
             assert rv.data.startswith(b"<?xml")
             assert b'<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">' in rv.data
             assert b"</urlset>" in rv.data
 
     def test_urls_names(self, app):
-        with app.test_client() as c:
-            rv = c.get(url_for("misc.urls_names"))
+        with app.test_client() as client:
+            rv = client.get(url_for("misc.urls_names"))
             assert rv.status == "200 OK"
             assert rv.headers["Content-Type"] == "text/plain; charset=utf-8"

src/moin/apps/serve/_tests/test_serve.py

@@ -10,14 +10,14 @@
 
 class TestServe:
     def test_index(self, app):
-        with app.test_client() as c:
-            rv = c.get(url_for("serve.index"))
+        with app.test_client() as client:
+            rv = client.get(url_for("serve.index"))
             assert rv.status == "200 OK"
             assert rv.headers["Content-Type"] == "text/plain"
 
     def test_files(self, app):
-        with app.test_client() as c:
-            rv = c.get(url_for("serve.files", name="DoesntExist"))
+        with app.test_client() as client:
+            rv = client.get(url_for("serve.files", name="DoesntExist"))
             assert rv.status == "404 NOT FOUND"
             assert rv.headers["Content-Type"] == "text/html; charset=utf-8"
             assert rv.text.startswith("<!doctype html")

src/moin/items/_tests/test_Blog.py

@@ -27,8 +27,8 @@ def set_self_app(self, app):
         self.app = app
 
     def _test_view(self, item_name, req_args={}, data_tokens=[], exclude_data_tokens=[], regex=None):
-        with self.app.test_client() as c:
-            rv = c.get(url_for("frontend.show_item", item_name=item_name, **req_args))
+        with self.app.test_client() as client:
+            rv = client.get(url_for("frontend.show_item", item_name=item_name, **req_args))
             rv_data = rv.data.decode()
             for data in data_tokens:
                 assert data in rv_data