Skip to content

Commit d2993b5

Browse files
committed
Add REV_NUMBER in sort for history view
1 parent 930397e commit d2993b5

File tree

1 file changed

+19
-5
lines changed

1 file changed

+19
-5
lines changed

src/moin/apps/frontend/views.py

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1491,15 +1491,22 @@ def mychanges():
14911491
if results_per_page:
14921492
len_revs = flaskg.storage.search_results_size(query, idx_name=ALL_REVS)
14931493
metas = flaskg.storage.search_meta_page(
1494-
query, idx_name=ALL_REVS, sortedby=[MTIME], reverse=True, pagenum=page_num, pagelen=results_per_page
1494+
query,
1495+
idx_name=ALL_REVS,
1496+
sortedby=[MTIME, REV_NUMBER],
1497+
reverse=True,
1498+
pagenum=page_num,
1499+
pagelen=results_per_page,
14951500
)
14961501
pages = (len_revs + results_per_page - 1) // results_per_page
14971502
if page_num > pages:
14981503
# user has entered bad page_num in url
14991504
page_num = pages
15001505
else:
15011506
pages = 1
1502-
metas = flaskg.storage.search_meta(query, idx_name=ALL_REVS, sortedby=[MTIME], reverse=True, limit=None)
1507+
metas = flaskg.storage.search_meta(
1508+
query, idx_name=ALL_REVS, sortedby=[MTIME, REV_NUMBER], reverse=True, limit=None
1509+
)
15031510

15041511
my_changes = []
15051512
for meta in metas:
@@ -1638,14 +1645,21 @@ def history(item_name):
16381645
if results_per_page:
16391646
len_revs = flaskg.storage.search_results_size(query, idx_name=ALL_REVS)
16401647
metas = flaskg.storage.search_meta_page(
1641-
query, idx_name=ALL_REVS, sortedby=[MTIME], reverse=True, pagenum=page_num, pagelen=results_per_page
1648+
query,
1649+
idx_name=ALL_REVS,
1650+
sortedby=[MTIME, REV_NUMBER],
1651+
reverse=True,
1652+
pagenum=page_num,
1653+
pagelen=results_per_page,
16421654
)
16431655
pages = (len_revs + results_per_page - 1) // results_per_page
16441656
if page_num > pages:
16451657
page_num = pages
16461658
else:
16471659
pages = 1
1648-
metas = flaskg.storage.search_meta(query, idx_name=ALL_REVS, sortedby=[MTIME], reverse=True, limit=None)
1660+
metas = flaskg.storage.search_meta(
1661+
query, idx_name=ALL_REVS, sortedby=[MTIME, REV_NUMBER], reverse=True, limit=None
1662+
)
16491663

16501664
# get rid of the content value to save potentially big amounts of memory:
16511665
history = []
@@ -2605,7 +2619,7 @@ def diff(item_name):
26052619
terms = [Term(WIKINAME, app.cfg.interwikiname)]
26062620
terms.extend(Term(term, value) for term, value in fqname.query.items())
26072621
query = And(terms)
2608-
metas = flaskg.storage.search_meta(query, idx_name=ALL_REVS, sortedby=[MTIME], reverse=True, limit=None)
2622+
metas = flaskg.storage.search_meta(query, idx_name=ALL_REVS, sortedby=[MTIME, REV_NUMBER], reverse=True, limit=None)
26092623
close_file(item.rev.data)
26102624
item = flaskg.storage.get_item(**fqname.query)
26112625
metas = [(int(meta[MTIME].replace(tzinfo=timezone.utc).timestamp()), meta[REVID], meta[ITEMID]) for meta in metas]

0 commit comments

Comments
 (0)