Skip to content

Commit 025fa33

Browse files
committed
only set gradle user home when making a binary.
1 parent 4c76524 commit 025fa33

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

cmake/rosjava.cmake.em

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,9 @@ macro(_rosjava_env)
5050
else()
5151
set(ROSJAVA_ENV "ROS_MAVEN_DEPLOYMENT_REPOSITORY=${ROS_MAVEN_DEPLOYMENT_REPOSITORY}")
5252
endif()
53-
set(ROSJAVA_GRADLE_USER_HOME $ENV{GRADLE_USER_HOME})
54-
if(NOT ROSJAVA_GRADLE_USER_HOME)
53+
# The build farm won't let you access /root/.gradle, so redirect it somewhere practical here.
54+
if(DEFINED CATKIN_BUILD_BINARY_PACKAGE)
5555
list(APPEND ROSJAVA_ENV "GRADLE_USER_HOME=${CATKIN_DEVEL_PREFIX}/${CATKIN_GLOBAL_GRADLE_DESTINATION}")
56-
else()
57-
list(APPEND ROSJAVA_ENV "GRADLE_USER_HOME=${ROSJAVA_GRADLE_USER_HOME}")
5856
endif()
5957
endmacro()
6058

@@ -67,14 +65,13 @@ macro(catkin_rosjava_setup)
6765
_rosjava_env()
6866
find_gradle()
6967
if( ${ARGC} EQUAL 0 )
70-
# Note : COMMAND is a list of variables, so these need to be a list, not a single string
71-
set(gradle_tasks "install;installApp;uploadArchives")
68+
# Note : COMMAND is a list of variables (semi-colon separated)
69+
set(gradle_tasks "publishMavenJavaPublicationToMavenRepository") # old targets "install;installApp;uploadArchives"
7270
else()
7371
set(gradle_tasks ${ARGV})
7472
endif()
7573
add_custom_target(gradle-${PROJECT_NAME}
7674
ALL
77-
COMMAND ${ROSJAVA_ENV} ${CATKIN_ENV} "env" "|" "grep" "GRADLE"
7875
COMMAND ${ROSJAVA_ENV} ${CATKIN_ENV} "env" "|" "grep" "ROS"
7976
COMMAND ${ROSJAVA_ENV} ${CATKIN_ENV} ${${PROJECT_NAME}_gradle_BINARY} ${gradle_tasks}
8077
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}

env-hooks/15.rosjava.bash.em

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,3 @@ SCRIPT=@(CMAKE_INSTALL_PREFIX)/share/rosjava_build_tools/generate_environment_va
88

99
export ROS_MAVEN_PATH=`python ${SCRIPT} --maven-path`
1010
export ROS_MAVEN_DEPLOYMENT_REPOSITORY=`python ${SCRIPT} --maven-deployment-repository`
11-
export GRADLE_USER_HOME=`python ${SCRIPT} --gradle-user-home`

env-hooks/15.rosjava.sh.em

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,3 @@ SCRIPT=@(CMAKE_INSTALL_PREFIX)/share/rosjava_build_tools/generate_environment_va
88

99
export ROS_MAVEN_PATH=`python ${SCRIPT} --maven-path`
1010
export ROS_MAVEN_DEPLOYMENT_REPOSITORY=`python ${SCRIPT} --maven-deployment-repository`
11-
export GRADLE_USER_HOME=`python ${SCRIPT} --gradle-user-home`

0 commit comments

Comments
 (0)