Skip to content

Commit 84278e7

Browse files
committed
target-sdk version bugfixing for catkin create projects.
1 parent 9a1a6e9 commit 84278e7

File tree

2 files changed

+20
-12
lines changed

2 files changed

+20
-12
lines changed

src/rosjava_build_tools/create_android_project.py

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ def parse_arguments():
2828
parser.add_argument('name',
2929
nargs=1,
3030
help='The name for the package')
31-
parser.add_argument('-s', '--sdk-version',
31+
parser.add_argument('-t', '--target-version',
3232
action='store',
33-
default='18.1.1',
34-
help='Android sdk version [18.1.1]')
33+
default='15',
34+
help='Target android version [15]')
3535
parser.add_argument('-p', '--android-package-name',
3636
action='store',
3737
default='com.github.rosjava.android.pkg_name',
@@ -46,27 +46,30 @@ def parse_arguments():
4646
return args
4747

4848

49-
def actually_create_android_project(package_name, sdk_version, java_package_name, is_library):
49+
def actually_create_android_project(package_name, target_version, java_package_name, is_library):
5050
path = os.path.join(os.getcwd(), package_name.lower())
5151
console.pretty_println("\nCreating android project ", console.bold)
5252
console.pretty_print(" Name : ", console.cyan)
5353
console.pretty_println("%s" % package_name, console.yellow)
54-
console.pretty_print(" Sdk Ver : ", console.cyan)
55-
console.pretty_println("%s" % sdk_version, console.yellow)
54+
console.pretty_print(" Target Ver: ", console.cyan)
55+
console.pretty_println("%s" % target_version, console.yellow)
5656
console.pretty_print(" Java Name : ", console.cyan)
5757
console.pretty_println("%s" % java_package_name, console.yellow)
5858
if is_library:
5959
console.pretty_print(" Library : ", console.cyan)
6060
console.pretty_println("yes\n", console.yellow)
61-
cmd = ['android', 'create', 'lib-project', '-n', package_name, '-p', path, '-k', java_package_name, '-t', 'android-' + sdk_version, ]
61+
cmd = ['android', 'create', 'lib-project', '-n', package_name, '-p', path, '-k', java_package_name, '-t', 'android-' + target_version, ]
6262
else:
6363
activity_name = utils.camel_case(package_name)
6464
console.pretty_print(" Activity : ", console.cyan)
6565
console.pretty_println("%s\n" % activity_name, console.yellow)
66-
cmd = ['android', 'create', 'project', '-n', package_name, '-p', path, '-k', java_package_name, '-t', 'android-' + sdk_version, '-a', activity_name]
66+
cmd = ['android', 'create', 'project', '-n', package_name, '-p', path, '-k', java_package_name, '-t', 'android-' + target_version, '-a', activity_name]
67+
print("Command: %s" % cmd)
6768
try:
6869
subprocess.check_call(cmd)
70+
print("Command: %s" % cmd)
6971
except subprocess.CalledProcessError:
72+
print("Error")
7073
raise subprocess.CalledProcessError("failed to create android project.")
7174
# This is in the old form, let's shovel the shit around to the new form
7275
utils.mkdir_p(os.path.join(path, 'src', 'main', 'java'))
@@ -157,8 +160,8 @@ def extra_gradle_library_text():
157160

158161
def create_android_project(is_library=False):
159162
args = parse_arguments()
160-
actually_create_android_project(args.name[0], args.sdk_version, args.android_package_name, is_library)
161-
create_gradle_package_files(args, args.author, is_library, args.sdk_version)
163+
actually_create_android_project(args.name[0], args.target_version, args.android_package_name, is_library)
164+
create_gradle_package_files(args, args.author, is_library, args.target_version)
162165
add_to_root_gradle_settings(args.name[0])
163166

164167
##############################################################################

src/rosjava_build_tools/templates/android_project/build.gradle.in

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,11 @@ dependencies {
3434
apply plugin: '%(plugin_name)s'
3535

3636
android {
37-
compileSdkVersion %(sdk_version)s
37+
packagingOptions {
38+
/* https://github.com/rosjava/android_core/issues/194 */
39+
exclude 'META-INF/LICENSE.txt'
40+
exclude 'META-INF/NOTICE.txt'
41+
}
42+
compileSdkVersion %(sdk_version)s
3843
}
39-
44+

0 commit comments

Comments
 (0)