Skip to content

Commit a999ed2

Browse files
committed
android script fixes
1 parent c505f4d commit a999ed2

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

scripts/catkin_create_android_pkg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import argparse
1111
import os
1212
import sys
1313

14-
from rosjava_build_tools import init_android_repo
14+
from rosjava_build_tools import init_android_package
1515
import rosjava_build_tools.console as console
1616

1717
##############################################################################

src/rosjava_build_tools/create_android_project.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def parse_arguments():
5050
return args
5151

5252

53-
def create_android_project(package_name, sdk_version, java_package_name, is_library):
53+
def actually_create_android_project(package_name, sdk_version, java_package_name, is_library):
5454
path = os.path.join(os.getcwd(), package_name.lower())
5555
console.pretty_println("\nCreating android project ", console.bold)
5656
console.pretty_print(" Name : ", console.cyan)
@@ -110,8 +110,8 @@ def create_gradle_package_files(args, author, is_library, sdk_version):
110110
filename = os.path.join(package_path, template_name)
111111
template = read_template_file(template_name)
112112
contents = instantiate_template(template, package_name, author, plugin_name, sdk_version)
113-
if is_library:
114-
contents += extra_gradle_library_text()
113+
#if is_library:
114+
# contents += extra_gradle_library_text()
115115
try:
116116
f = open(filename, 'w')
117117
f.write(contents)
@@ -142,6 +142,9 @@ def add_to_root_gradle_settings(name):
142142

143143

144144
def extra_gradle_library_text():
145+
'''
146+
Not actually necessary until we start using maven-publish plugin. It doesn't handle dependencies right now.
147+
'''
145148
text = "\n"
146149
text += "/* http://www.flexlabs.org/2013/06/using-local-aar-android-library-packages-in-gradle-builds */\n"
147150
text += "android.libraryVariants\n"
@@ -158,7 +161,7 @@ def extra_gradle_library_text():
158161

159162
def create_android_project(is_library=False):
160163
args = parse_arguments()
161-
create_android_project(args.name[0], args.sdk_version, args.android_package_name, is_library)
164+
actually_create_android_project(args.name[0], args.sdk_version, args.android_package_name, is_library)
162165
create_gradle_package_files(args, args.author, is_library, args.sdk_version)
163166
add_to_root_gradle_settings(args.name[0])
164167

0 commit comments

Comments
 (0)