6.4.19-rc1 (#1600)

- Accelerated connection establishment
- Fixed joining of groups/channels after a longer period of being
offline
IOS_ONLY - Fixed long delay when sometimes answering an incoming call

Author: tmolitor-stud-tu

Monal/Classes/DataLayer.m

@@ -357,19 +357,11 @@ -(NSMutableDictionary*) readStateForAccount:(NSNumber*) accountNo
         return nil;
     NSString* query = @"SELECT state from account where account_id=?";
     NSArray* params = @[accountNo];
-    DDLogVerbose(@"Outside of transaction: Reading account state: %@", accountNo);
-    [MLSQLite debugTransactions];
     NSData* data = (NSData*)[self.db idReadTransaction:^{
-        DDLogVerbose(@"Inside of transaction: Reading account state: %@", accountNo);
         return [self.db executeScalar:query andArguments:params];
     }];
-    DDLogVerbose(@"After transaction: Reading account state: %@ --> %@", accountNo, data);
     if(data)
-    {
-        NSMutableDictionary* retval = [HelperTools unserializeData:data];
-        DDLogVerbose(@"After unserializeData: Reading account state: %@", accountNo);
-        return retval;
-    }
+        return [HelperTools unserializeData:data];
     return nil;
 }
 

Monal/Classes/HelperTools.m

@@ -702,16 +702,18 @@ +(NSRunLoop*) getExtraRunloopWithIdentifier:(MLRunLoopIdentifier) identifier
             NSCondition* condition = [NSCondition new];
             [condition lock];
             NSThread* newRunloopThread = [[NSThread alloc] initWithBlock:^{
-                //we don't need an @synchronized block around this because the @synchronized block of the outer thread
-                //waits until we signal our condition (e.g. no other thread can race with us)
-                NSRunLoop* localLoop = runloops[@(identifier)] = [NSRunLoop currentRunLoop];
-                [condition lock];
-                [condition signal];
-                [condition unlock];
-                while(YES)
-                {
-                    [localLoop run];
-                    usleep(10000);          //sleep 10ms if we ever return from our runloop to not consume too much cpu
+                @autoreleasepool {
+                    //we don't need an @synchronized block around this because the @synchronized block of the outer thread
+                    //waits until we signal our condition (e.g. no other thread can race with us)
+                    NSRunLoop* localLoop = runloops[@(identifier)] = [NSRunLoop currentRunLoop];
+                    [condition lock];
+                    [condition signal];
+                    [condition unlock];
+                    while(YES)
+                    {
+                        [localLoop run];
+                        usleep(10000);          //sleep 10ms if we ever return from our runloop to not consume too much cpu
+                    }
                 }
             }];
             //configure and start thread

Monal/Classes/IPC.m

@@ -199,56 +199,58 @@ -(id) initWithProcessName:(NSString*) processName
 
 -(void) serverThreadMain
 {
-    DDLogInfo(@"Now running IPC server for '%@' with thread priority %f...", _processName, [NSThread threadPriority]);
-    //register darwin notification handler for "im.monal.ipc.wakeup:<process name>" which is used to wake up readNextMessage using the NSCondition
-    CFNotificationCenterAddObserver(_darwinNotificationCenterRef, (__bridge void*) self, &darwinNotificationCenterCallback, (__bridge CFNotificationName)[NSString stringWithFormat:@"im.monal.ipc.wakeup:%@", _processName], NULL, 0);
-    CFNotificationCenterAddObserver(_darwinNotificationCenterRef, (__bridge void*) self, &darwinNotificationCenterCallback, (__bridge CFNotificationName)@"im.monal.ipc.wakeup:*", NULL, 0);
-    while(![[NSThread currentThread] isCancelled])
-    {
-        NSDictionary* message = [self readNextMessage];     //this will be blocking
-        if(!message)
-            continue;
-        DDLogDebug(@"Got IPC message: %@", message);
-        
-        //use a dedicated serial queue for every IPC receiver to maintain IPC message ordering while not blocking other receivers or this serverThread)
-        NSArray* parts = [message[@"name"] componentsSeparatedByString:@"."];
-        NSString* queueName = [parts objectAtIndex:0];
-        if(!queueName || [parts count]<2)
-            queueName = @"_default";
-        queueName = [NSString stringWithFormat:@"ipc.queue:%@", queueName];
-        if(!_ipcQueues[queueName])
-            _ipcQueues[queueName] = dispatch_queue_create([queueName cStringUsingEncoding:NSUTF8StringEncoding], dispatch_queue_attr_make_with_qos_class(DISPATCH_QUEUE_SERIAL, QOS_CLASS_USER_INTERACTIVE, 0));
-        
-        //handle all responses (don't trigger a kMonalIncomingIPC for responses)
-        if(message[@"response_to"] && [message[@"response_to"] intValue] > 0)
+    @autoreleasepool {
+        DDLogInfo(@"Now running IPC server for '%@' with thread priority %f...", _processName, [NSThread threadPriority]);
+        //register darwin notification handler for "im.monal.ipc.wakeup:<process name>" which is used to wake up readNextMessage using the NSCondition
+        CFNotificationCenterAddObserver(_darwinNotificationCenterRef, (__bridge void*) self, &darwinNotificationCenterCallback, (__bridge CFNotificationName)[NSString stringWithFormat:@"im.monal.ipc.wakeup:%@", _processName], NULL, 0);
+        CFNotificationCenterAddObserver(_darwinNotificationCenterRef, (__bridge void*) self, &darwinNotificationCenterCallback, (__bridge CFNotificationName)@"im.monal.ipc.wakeup:*", NULL, 0);
+        while(![[NSThread currentThread] isCancelled])
         {
-            //call response handler if one is present (ignore the spurious response otherwise)
-            if(_responseHandlers[message[@"response_to"]])
+            NSDictionary* message = [self readNextMessage];     //this will be blocking
+            if(!message)
+                continue;
+            DDLogDebug(@"Got IPC message: %@", message);
+            
+            //use a dedicated serial queue for every IPC receiver to maintain IPC message ordering while not blocking other receivers or this serverThread)
+            NSArray* parts = [message[@"name"] componentsSeparatedByString:@"."];
+            NSString* queueName = [parts objectAtIndex:0];
+            if(!queueName || [parts count]<2)
+                queueName = @"_default";
+            queueName = [NSString stringWithFormat:@"ipc.queue:%@", queueName];
+            if(!_ipcQueues[queueName])
+                _ipcQueues[queueName] = dispatch_queue_create([queueName cStringUsingEncoding:NSUTF8StringEncoding], dispatch_queue_attr_make_with_qos_class(DISPATCH_QUEUE_SERIAL, QOS_CLASS_USER_INTERACTIVE, 0));
+            
+            //handle all responses (don't trigger a kMonalIncomingIPC for responses)
+            if(message[@"response_to"] && [message[@"response_to"] intValue] > 0)
             {
-                IPC_response_handler_t responseHandler = (IPC_response_handler_t)_responseHandlers[message[@"response_to"]];
-                if(responseHandler)
+                //call response handler if one is present (ignore the spurious response otherwise)
+                if(_responseHandlers[message[@"response_to"]])
                 {
-                    //responses handlers are only valid for the maximum RTT of messages (+ some safety margin)
-                    createTimer(MSG_TIMEOUT*2 + 1, (^{
-                        [_responseHandlers removeObjectForKey:message[@"response_to"]];
-                    }));
-                    dispatch_async(_ipcQueues[queueName], ^{
-                        responseHandler(message);
-                    });
+                    IPC_response_handler_t responseHandler = (IPC_response_handler_t)_responseHandlers[message[@"response_to"]];
+                    if(responseHandler)
+                    {
+                        //responses handlers are only valid for the maximum RTT of messages (+ some safety margin)
+                        createTimer(MSG_TIMEOUT*2 + 1, (^{
+                            [_responseHandlers removeObjectForKey:message[@"response_to"]];
+                        }));
+                        dispatch_async(_ipcQueues[queueName], ^{
+                            responseHandler(message);
+                        });
+                    }
                 }
             }
+            else        //publish all non-responses (using the message name as object allows for filtering by ipc message name)
+                dispatch_async(_ipcQueues[queueName], ^{
+                    [[NSNotificationCenter defaultCenter] postNotificationName:kMonalIncomingIPC object:message[@"name"] userInfo:message];
+                });
+            
+            DDLogDebug(@"Handled IPC message: %@", message);
         }
-        else        //publish all non-responses (using the message name as object allows for filtering by ipc message name)
-            dispatch_async(_ipcQueues[queueName], ^{
-                [[NSNotificationCenter defaultCenter] postNotificationName:kMonalIncomingIPC object:message[@"name"] userInfo:message];
-            });
-        
-        DDLogDebug(@"Handled IPC message: %@", message);
+        //unregister darwin notification handler
+        CFNotificationCenterRemoveObserver(_darwinNotificationCenterRef, (__bridge void*) self, (__bridge CFNotificationName)[NSString stringWithFormat:@"im.monal.ipc.wakeup:%@", _processName], NULL);
+        CFNotificationCenterRemoveObserver(_darwinNotificationCenterRef, (__bridge void*) self, (__bridge CFNotificationName)@"im.monal.ipc.wakeup:*", NULL);
+        DDLogInfo(@"IPC server for '%@' now terminated", _processName);
     }
-    //unregister darwin notification handler
-    CFNotificationCenterRemoveObserver(_darwinNotificationCenterRef, (__bridge void*) self, (__bridge CFNotificationName)[NSString stringWithFormat:@"im.monal.ipc.wakeup:%@", _processName], NULL);
-    CFNotificationCenterRemoveObserver(_darwinNotificationCenterRef, (__bridge void*) self, (__bridge CFNotificationName)@"im.monal.ipc.wakeup:*", NULL);
-    DDLogInfo(@"IPC server for '%@' now terminated", _processName);
 }
 
 -(void) incomingDarwinNotification:(NSString*) name

Monal/Classes/MLDelayedDealloc.h

@@ -0,0 +1,17 @@
+//
+//  MLDelayedDealloc.h
+//  monalxmpp
+//
+//  Created by Thilo Molitor on 04.03.26.
+//  Copyright © 2026 Monal.im. All rights reserved.
+//
+
+NS_ASSUME_NONNULL_BEGIN
+
+@interface MLDelayedDealloc : NSObject
+
++(void) delayFor:(id) obj;
+
+@end
+
+NS_ASSUME_NONNULL_END