Skip to content

Commit e2c5bea

Browse files
committed
feat: limit upload of specific file to 50mb [beta]
1 parent 6a0f647 commit e2c5bea

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

lib/minimal-package.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export default { name: '@mondaycom/apps-sdk', version: '3.3.0' };
1+
export default { name: '@mondaycom/apps-sdk', version: '3.3.0-beta.7' };

lib/object-storage/object-storage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ export class ObjectStorage {
222222
const fifteenMinutesFromNow = new Date(Date.now() + TIME_IN_MILLISECOND.MINUTE * 15);
223223
const expires = options.expires || fifteenMinutesFromNow;
224224

225-
const maxFileSizeBytes = options.maxFileSizeBytes || (50 * 1024 * 1024 * 1024);
225+
const maxFileSizeBytes = options.maxFileSizeBytes || (50 * 1024 * 1024);
226226

227227
const signedUrlOptions = {
228228
version: 'v4' as const,

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@mondaycom/apps-sdk",
3-
"version": "3.3.0",
3+
"version": "3.3.0-beta.7",
44
"description": "monday apps SDK for NodeJS",
55
"main": "./dist/cjs/index.js",
66
"module": "./dist/esm/index.js",

tests/object-storage/object-storage.test.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ describe('ObjectStorage', () => {
304304
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
305305
expires: expect.any(Date),
306306
extensionHeaders: {
307-
'x-goog-content-length-range': '0,53687091200', // 50 GB default limit
307+
'x-goog-content-length-range': '0,52428800', // 50 MB default limit
308308
},
309309
});
310310
});
@@ -326,7 +326,7 @@ describe('ObjectStorage', () => {
326326
action: 'write',
327327
expires: customExpires,
328328
extensionHeaders: {
329-
'x-goog-content-length-range': '0,53687091200', // 50 GB default limit
329+
'x-goog-content-length-range': '0,52428800', // 50 MB default limit
330330
},
331331
});
332332
});
@@ -350,7 +350,7 @@ describe('ObjectStorage', () => {
350350
expires: expect.any(Date),
351351
contentType: 'text/plain',
352352
extensionHeaders: {
353-
'x-goog-content-length-range': '0,53687091200', // 50 GB default limit
353+
'x-goog-content-length-range': '0,52428800', // 50 MB default limit
354354
},
355355
});
356356
});
@@ -377,7 +377,7 @@ describe('ObjectStorage', () => {
377377
expires: customExpires,
378378
contentType: 'application/json',
379379
extensionHeaders: {
380-
'x-goog-content-length-range': '0,53687091200', // 50 GB default limit
380+
'x-goog-content-length-range': '0,52428800', // 50 MB default limit
381381
},
382382
});
383383
});
@@ -401,7 +401,7 @@ describe('ObjectStorage', () => {
401401
action: 'write',
402402
expires: new Date(mockNow + 15 * 60 * 1000), // 15 minutes from mockNow
403403
extensionHeaders: {
404-
'x-goog-content-length-range': '0,53687091200', // 50 GB default limit
404+
'x-goog-content-length-range': '0,52428800', // 50 MB default limit
405405
},
406406
});
407407

@@ -432,10 +432,10 @@ describe('ObjectStorage', () => {
432432
expect(result.error).toContain('Failed to generate presigned upload URL');
433433
});
434434

435-
it('should enforce 50 GB max file size limit', async () => {
435+
it('should enforce 50 MB max file size limit', async () => {
436436
const fileName = 'large-file.bin';
437437
const expectedUrl = 'https://storage.googleapis.com/test-bucket/large-file.bin?signed-url-params';
438-
const fiftyGBInBytes = 50 * 1024 * 1024 * 1024; // 53,687,091,200 bytes
438+
const fiftyMBInBytes = 50 * 1024 * 1024; // 52,428,800 bytes
439439

440440
mockFile.getSignedUrl.mockResolvedValueOnce([expectedUrl]);
441441

@@ -445,7 +445,7 @@ describe('ObjectStorage', () => {
445445
expect(mockFile.getSignedUrl).toHaveBeenCalledWith(
446446
expect.objectContaining({
447447
extensionHeaders: {
448-
'x-goog-content-length-range': `0,${fiftyGBInBytes}`,
448+
'x-goog-content-length-range': `0,${fiftyMBInBytes}`,
449449
},
450450
}),
451451
);

0 commit comments

Comments
 (0)