Skip to content

Commit 72e7ef5

Browse files
rivka-ungarclaude
andcommitted
docs: address Talkor's review feedback on changelog and migration guide
Remove internal implementation details (usePopover, Refable, CustomSvgIcon section), fix codemod CLI syntax to use correct -m v4 flag, move MCP tip below migration steps, add missing --docs suffix to changelog link, and improve Chips/DatePicker descriptions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 52e35db commit 72e7ef5

File tree

2 files changed

+15
-23
lines changed

2 files changed

+15
-23
lines changed

packages/docs/src/pages/migration-guide/vibe-4-changelog.md

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
This is the complete list of changes in the Vibe 4 release. Changes that are marked with a 🔀 are covered by a migration script (codemod).
44

5-
For the complete migration guide see the [Vibe 4 Migration Guide](https://vibe.monday.com/?path=/docs/vibe-4-migration-guide).
5+
For the complete migration guide see the [Vibe 4 Migration Guide](https://vibe.monday.com/?path=/docs/vibe-4-migration-guide--docs).
66

77
## General
88

@@ -63,20 +63,16 @@ Note: Component-specific compound props like `inputAriaLabel`, `menuAriaLabel`,
6363

6464
### Chips
6565

66-
- The `disableClickableBehavior` prop has been removed 🔀
66+
- The `disableClickableBehavior` prop has been removed — Chips now always uses the clickable wrapper when click handlers are provided 🔀
6767

6868
### Clickable
6969

7070
- `ariaHasPopup` now accepts `boolean` only (was `boolean | string`)
7171
- `tabIndex` now accepts `number` only (was `string | number`)
7272

73-
### CustomSvgIcon
74-
75-
- The `onClick` and `clickable` props have been removed — wrap with a clickable element instead
76-
7773
### DatePicker
7874

79-
- Legacy DatePicker (`react-dates` + `moment`) replaced with new implementation (`react-day-picker` + `date-fns`)
75+
- Legacy DatePicker (`react-dates` + `moment`) replaced with new implementation (`react-day-picker` + `date-fns`) with an updated visual design
8076
- `date` prop type changed from `moment.Moment` to `Date`
8177
- `onPickDate` renamed to `onDateChange`
8278
- `range` boolean prop replaced with `mode: "single" | "range"`
@@ -88,8 +84,6 @@ Note: Component-specific compound props like `inputAriaLabel`, `menuAriaLabel`,
8884
- `modifiers` prop removed — use `middleware` prop instead
8985
- `enableNestedDialogLayer` prop removed — `LayerProvider` is always used
9086
- `addKeyboardHideShowTriggersByDefault` default changed to `true`
91-
- `usePopover` hook removed from `@vibe/dialog`
92-
- `Refable` component removed from public exports
9387
- Removed dependencies: `react-popper`, `@popperjs/core`
9488
- Added dependency: `@floating-ui/react-dom`
9589

@@ -117,6 +111,7 @@ Note: Component-specific compound props like `inputAriaLabel`, `menuAriaLabel`,
117111
- `iconType` prop renamed to `type` 🔀
118112
- `iconSize` prop renamed to `size` 🔀
119113
- `size` prop now applies to `type="src"` icons (previously only affected `type="svg"`)
114+
- `onClick` and `clickable` props removed from internal `CustomSvgIcon` — wrap with a clickable element (e.g. `<IconButton>`) instead
120115

121116
### LinearProgressBar (ProgressBar)
122117

packages/docs/src/pages/migration-guide/vibe-4-migration-guide.mdx

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,6 @@ import { DiffCodeBlock } from "./DiffCodeBlock";
88

99
<br />
1010

11-
<Tip type="success" title="NEW! AI-powered migration available!" emoji={false}>
12-
**Skip the manual work and let AI handle your entire Vibe 4 migration!** With the [Vibe MCP
13-
server](?path=/docs/mcp-new--docs), simply ask your AI assistant: *"Help me migrate this
14-
project from Vibe 3 to Vibe 4"* and it will automatically scan your codebase, identify all breaking changes, and run
15-
the exact codemods you need.
16-
<br /> <br /> **[Install the MCP →](?path=/docs/mcp-new--docs) and turn your migration into
17-
minutes!**
18-
</Tip>
19-
2011
<div style={{ lineHeight: "1.8" }}>
2112

2213
- [Intro](#intro)
@@ -96,6 +87,12 @@ Input components (TextField, TextArea, Dropdown) now have reduced inline padding
9687

9788
5. Run your code formatter to clean up any formatting changes from the codemod (optional).
9889

90+
<Tip type="success" title="AI-powered migration" emoji={false}>
91+
You can also use the [Vibe MCP server](?path=/docs/mcp-new--docs) with your AI assistant to automate
92+
the migration. Ask: *"Help me migrate this project from Vibe 3 to Vibe 4"* and it will scan your
93+
codebase, identify breaking changes, and run the codemods for you.
94+
</Tip>
95+
9996
## Breaking Changes 🚨
10097

10198
The following changes are **complementary to the migration codemod** and may require manual intervention. If you prefer to migrate entirely by hand (without `@vibe/codemod`), refer to the [Complete Vibe 4 changelog](https://github.com/mondaycom/vibe/blob/master/packages/docs/src/pages/migration-guide/vibe-4-changelog.md).
@@ -282,7 +279,7 @@ The `"stretch"` value has been removed from the `justify` prop:
282279

283280
Props have been renamed to remove the redundant "icon" prefix:
284281

285-
**Codemod available**: `npx @vibe/codemod icon-props-rename`
282+
**Handled by codemod** (`npx @vibe/codemod -m v4`)
286283

287284
<ul>
288285
<DiffCodeBlock
@@ -392,7 +389,7 @@ The finish button now renders by default on the last step. To hide it, explicitl
392389

393390
The `tooltipPosition` prop has been removed. Use `tooltipProps` instead:
394391

395-
**Codemod available**: `npx @vibe/codemod TextWithHighlight-component-migration`
392+
**Handled by codemod** (`npx @vibe/codemod -m v4`)
396393

397394
<ul>
398395
<DiffCodeBlock
@@ -406,7 +403,7 @@ The `tooltipPosition` prop has been removed. Use `tooltipProps` instead:
406403

407404
`TipseenImage` has been removed. Use `TipseenMedia` with an `<img>` child:
408405

409-
**Codemod available**: `npx @vibe/codemod TipseenImage-component-migration`
406+
**Handled by codemod** (`npx @vibe/codemod -m v4`)
410407

411408
<ul>
412409
<DiffCodeBlock
@@ -422,7 +419,7 @@ The `tooltipPosition` prop has been removed. Use `tooltipProps` instead:
422419

423420
1. The `noSpacing` prop has been removed. When `areLabelsHidden` is `true`, margin is removed automatically:
424421

425-
**Codemod available**: `npx @vibe/codemod Toggle-component-migration`
422+
**Handled by codemod** (`npx @vibe/codemod -m v4`)
426423

427424
<ul>
428425
<DiffCodeBlock
@@ -565,7 +562,7 @@ Most components from `@vibe/core/next` (AttentionBox, Dropdown, DatePicker, Dial
565562

566563
**Do I need to update my ARIA props?**
567564

568-
Yes. All custom camelCase ARIA props (`ariaLabel`, `ariaHidden`, etc.) have been replaced with standard `aria-*` attributes. Run `npx @vibe/codemod aria-props-migration` to migrate automatically.
565+
Yes. All custom camelCase ARIA props (`ariaLabel`, `ariaHidden`, etc.) have been replaced with standard `aria-*` attributes. Run `npx @vibe/codemod -m v4` to migrate automatically.
569566

570567
**What if the codemod doesn't cover my use case?**
571568

0 commit comments

Comments
 (0)