Allow more characters in machine dropdowns

[geoffsimons]

When editing a game's machine, or when making picks, machine names should allow enough characters such that distinctions between "Star Trek (Stern)" and "Star Trek (Bally)", which might currently both display as "Star Trek (".

[geoffsimons]

This is from template/game.js
Concat'ing a bunch of strings together and setting an innerHTML is pretty old school. Note the subtring(0,10), which is the main culprit. I may try to re-implement this with jQuery, since it's already available in the page (and is used just below this function in the file).

function makeSelect(name, options, selected) {
  var html = '<select id="' +name+ '" class="custom-select">';
  for(var i = 0; i < options.length; i++) {
    var opt = options[i];
    var value = opt.value || opt;
    var label = opt.label || labels[opt];
    if(label.length > 10) {
      label = label.substring(0,10);
    }
    var sel = opt == selected ? ' selected' : '';
    html += '<option value="' +value+ '"' +sel+ '>' +label+ '</option>';
  }
  html += '</select>';
  return html;
}

[geoffsimons]

It gets worse... There are actually 4 copies of almost the same makeSelect method. It probably makes sense to move them all into one file and include that where needed, but it kind of hurts to do those kinds of fixes knowing that the frontend should mostly be re-written from the ground up. That said, an updated util might be useful in the new frontend, so maybe not a total waste of time.

[geoffsimons]

The fix for now seems to be the fact that only game.js contains the truncated makeSelect, and that is only visible when a game is being edited. The substring was added to help fit everything on the screen for player names, at the expense of truncating the names. Seems that a small CSS patch might help get the selects to fit.