chore(storage): address PR feedbacks

Author: mt-rory

src/__tests__/storage.test.ts

@@ -31,9 +31,9 @@ describe('storage', () => {
     window.sessionStorage = originalSessionStorage;
   });
 
-  test('getStorageObject throws if storage contains invalid JSON', () => {
+  test('returns undefined if storage contains invalid JSON', () => {
     window.localStorage.setItem(STORE_KEY, '{invalid json}');
-    expect(() => get('key1')).toThrow('Failed to retrieve mt-link-javascript-sdk data from storage');
+    expect(get('key1')).toBeUndefined();
   });
 
   test('set, get', () => {

src/storage.ts

@@ -4,11 +4,24 @@ interface StorageData {
   [key: string]: string;
 }
 
+function isStorageAvailable(storage: Storage): boolean {
+  try {
+    const test = '__storage_test__';
+    storage.setItem(test, test);
+    storage.removeItem(test);
+    return true;
+  } catch (_) {
+    return false;
+  }
+}
+
 function getAvailableStorage(): Storage {
-  if (typeof window.localStorage !== 'undefined' && window.localStorage !== null) return window.localStorage;
+  if (isStorageAvailable(window.localStorage)) return window.localStorage;
 
-  // Fallback to sessionStorage
-  if (typeof window.sessionStorage !== 'undefined' && window.sessionStorage !== null) return window.sessionStorage;
+  if (isStorageAvailable(window.sessionStorage)) {
+    console.error('localStorage not available, falling back to sessionStorage');
+    return window.sessionStorage;
+  }
 
   throw new Error('Neither localStorage nor sessionStorage is available');
 }
@@ -22,18 +35,14 @@ function getStorageObject(): StorageData {
 
     return JSON.parse(stringifiedData);
   } catch (error) {
-    throw new Error(`Failed to retrieve ${STORE_KEY} data from storage`);
+    console.error(`Failed to load or parse data from storage key "${STORE_KEY}":`, error);
+    return {};
   }
 }
 
 function saveStorageObject(data: StorageData): void {
   const storage = getAvailableStorage();
-
-  try {
-    storage.setItem(STORE_KEY, JSON.stringify(data));
-  } catch (error) {
-    throw new Error('Failed to save data to storage');
-  }
+  storage.setItem(STORE_KEY, JSON.stringify(data));
 }
 
 export function get(key: string): string | undefined {