ME_CONFIG_HEALTH_CHECK_PATH has no effect

[lordslair]

Hi,

Apparently, a couple of ENV Vars have no impact on mongo-express
I tried to have access to /status URL for Kubernetes livenessProbe (healthcheck)

Apparently, with or without setting the env var, it fails, and returns a 404

Here, the snippet from the K8s YAML:

      containers:
      - name: mongo-express
        image: mongo-express:1.0.0
        env:
[...]
        - name: ME_CONFIG_HEALTH_CHECK_PATH
          value: "/status"
        # Network
        ports:
        - name: mongo-express
          containerPort: 8081
        # Healthcheck
        livenessProbe:
            httpGet:
              path: /status
              port: 8081
            initialDelaySeconds: 10
            timeoutSeconds: 5

The ENV VArs are properly progagated:

mongo-express-7f4dddfc6-4fcqc:/node_modules/mongo-express# env | grep CHECK
ME_CONFIG_HEALTH_CHECK_PATH=/status

And there's the mongo-express related logs

No custom config.js found, loading config.default.js
Welcome to mongo-express
------------------------


Mongo Express server listening at http://0.0.0.0:8081
Server is open to allow connections from anyone (0.0.0.0)
basicAuth credentials are "admin:pass", it is recommended you change this in your config.js!
GET /status 404 495.004 ms - 145
GET /status 404 696.116 ms - 145

I tried without setting ME_CONFIG_HEALTH_CHECK_PATH, and same thing, HTTP404 on /status (as I suppose it's the deafult value)

Is there something I missed, or is it a bug ?

[rtritto]

Code of Docker version should be outdated.

Feature is introduced with mongo-express/mongo-express#940.

Please can you check the code?

[lordslair]

I will do so, and test locally the proposed modifications to check if that fixes the issue

[xTudoS]

I will do so, and test locally the proposed modifications to check if that fixes the issue

Any updates?

[lordslair]

Code of Docker version should be outdated.

Feature is introduced with mongo-express/mongo-express#940.

Please can you check the code?

Hello, orry for taking so long

I used the proposed code in that PR in my container, and it worked

mongo-express-7586d49f47-t6cjq:/node_modules/mongo-express# wget -qO- 127.0.0.1:8081/status
{"status":"ok"}

I tried it with and without setting ME_CONFIG_HEALTH_CHECK_PATH to check the default value used, and from what I can tell, everything is fine

[lordslair]

So, do you think this part of the code can be updated ? :D

To continue to use it in my K8s platform, I disabled my livenessProbe and readinessProbe
That's not crucial, but it could be a nice feature to have

[lordslair]

@rtritto as the issue you linked (mongo-express/mongo-express#940) was merged into the main codebase
And that patch has a very positive impact for monitoring purposes

Do you think the mongo-express-docker could be rebuilt ?

[rtritto]

@rtritto as the issue you linked (mongo-express/mongo-express#940) was merged into the main codebase And that patch has a very positive impact for monitoring purposes

Do you think the mongo-express-docker could be rebuilt ?

@BlackthornYugen what's the point?