indexes

Author: timgraham

tests/indexes/tests.py

@@ -2,7 +2,7 @@
 from unittest import skipUnless
 
 from django.conf import settings
-from django.db import connection
+from django.db import NotSupportedError, connection
 from django.db.models import (
     CASCADE,
     CharField,
@@ -405,9 +405,9 @@ def test_partial_index(self):
                     ),
                 ),
             )
-            self.assertIn(
-                "WHERE %s" % editor.quote_name("pub_date"),
-                str(index.create_sql(Article, schema_editor=editor)),
+            self.assertEqual(
+                {"pub_date": {"$gt": datetime.datetime(2015, 1, 1, 6, 0)}},
+                index._get_condition_mql(Article, schema_editor=editor),
             )
             editor.add_index(index=index, model=Article)
             with connection.cursor() as cursor:
@@ -424,12 +424,13 @@ def test_integer_restriction_partial(self):
         with connection.schema_editor() as editor:
             index = Index(
                 name="recent_article_idx",
-                fields=["id"],
+                # This is changed
+                fields=["headline"],
                 condition=Q(pk__gt=1),
             )
-            self.assertIn(
-                "WHERE %s" % editor.quote_name("id"),
-                str(index.create_sql(Article, schema_editor=editor)),
+            self.assertEqual(
+                {"_id": {"$gt": 1}},
+                index._get_condition_mql(Article, schema_editor=editor),
             )
             editor.add_index(index=index, model=Article)
             with connection.cursor() as cursor:
@@ -449,9 +450,9 @@ def test_boolean_restriction_partial(self):
                 fields=["published"],
                 condition=Q(published=True),
             )
-            self.assertIn(
-                "WHERE %s" % editor.quote_name("published"),
-                str(index.create_sql(Article, schema_editor=editor)),
+            self.assertEqual(
+                {"published": {"$eq": True}},
+                index._get_condition_mql(Article, schema_editor=editor),
             )
             editor.add_index(index=index, model=Article)
             with connection.cursor() as cursor:
@@ -479,15 +480,24 @@ def test_multiple_conditions(self):
                             tzinfo=timezone.get_current_timezone(),
                         )
                     )
-                    & Q(headline__contains="China")
+                    & Q(headline="China")
                 ),
             )
-            sql = str(index.create_sql(Article, schema_editor=editor))
-            where = sql.find("WHERE")
-            self.assertIn("WHERE (%s" % editor.quote_name("pub_date"), sql)
+            sql = index._get_condition_mql(Article, schema_editor=editor)
+            self.assertEqual(
+                sql,
+                {
+                    "$and": [
+                        {"pub_date": {"$gt": datetime.datetime(2015, 1, 1, 6, 0)}},
+                        {"headline": {"$eq": "China"}},
+                    ]
+                },
+            )
+            # where = sql.find("WHERE")
+            # self.assertIn("WHERE (%s" % editor.quote_name("pub_date"), sql)
             # Because each backend has different syntax for the operators,
             # check ONLY the occurrence of headline in the SQL.
-            self.assertGreater(sql.rfind("headline"), where)
+            # self.assertGreater(sql.rfind("headline"), where)
             editor.add_index(index=index, model=Article)
             with connection.cursor() as cursor:
                 self.assertIn(
@@ -500,26 +510,17 @@ def test_multiple_conditions(self):
             editor.remove_index(index=index, model=Article)
 
     def test_is_null_condition(self):
-        with connection.schema_editor() as editor:
-            index = Index(
-                name="recent_article_idx",
-                fields=["pub_date"],
-                condition=Q(pub_date__isnull=False),
-            )
-            self.assertIn(
-                "WHERE %s IS NOT NULL" % editor.quote_name("pub_date"),
-                str(index.create_sql(Article, schema_editor=editor)),
-            )
-            editor.add_index(index=index, model=Article)
-            with connection.cursor() as cursor:
-                self.assertIn(
-                    index.name,
-                    connection.introspection.get_constraints(
-                        cursor=cursor,
-                        table_name=Article._meta.db_table,
-                    ),
-                )
-            editor.remove_index(index=index, model=Article)
+        msg = "MongoDB does not support the 'isnull' lookup in indexes."
+        index = Index(
+            name="recent_article_idx",
+            fields=["pub_date"],
+            condition=Q(pub_date__isnull=False),
+        )
+        with (
+            self.assertRaisesMessage(NotSupportedError, msg),
+            connection.schema_editor() as editor,
+        ):
+            index._get_condition_mql(Article, schema_editor=editor)
 
     @skipUnlessDBFeature("supports_expression_indexes")
     def test_partial_func_index(self):