edits for many test apps

Author: timgraham

tests/admin_utils/test_logentry.py

@@ -202,7 +202,7 @@ def test_logentry_get_admin_url(self):
             "admin:admin_utils_article_change", args=(quote(self.a1.pk),)
         )
         self.assertEqual(logentry.get_admin_url(), expected_url)
-        self.assertIn("article/%d/change/" % self.a1.pk, logentry.get_admin_url())
+        self.assertIn("article/%s/change/" % self.a1.pk, logentry.get_admin_url())
 
         logentry.content_type.model = "nonexistent"
         self.assertIsNone(logentry.get_admin_url())

tests/auth_tests/test_context_processors.py

@@ -140,7 +140,7 @@ def test_user_attrs(self):
         user = authenticate(username="super", password="secret")
         response = self.client.get("/auth_processor_user/")
         self.assertContains(response, "unicode: super")
-        self.assertContains(response, "id: %d" % self.superuser.pk)
+        self.assertContains(response, "id: %s" % self.superuser.pk)
         self.assertContains(response, "username: super")
         # bug #12037 is tested by the {% url %} in the template:
         self.assertContains(response, "url: /userpage/super/")

tests/auth_tests/test_management.py

@@ -610,10 +610,12 @@ def test_validate_fk(self):
 
     @override_settings(AUTH_USER_MODEL="auth_tests.CustomUserWithFK")
     def test_validate_fk_environment_variable(self):
+        from bson import ObjectId
+
         email = Email.objects.create(email="[email protected]")
         Group.objects.all().delete()
-        nonexistent_group_id = 1
-        msg = f"group instance with id {nonexistent_group_id} does not exist."
+        nonexistent_group_id = ObjectId()
+        msg = f"group instance with id {nonexistent_group_id!r} does not exist."
 
         with mock.patch.dict(
             os.environ,
@@ -1532,5 +1534,5 @@ def test_set_permissions_fk_to_using_parameter(self):
         Permission.objects.using("other").delete()
         with self.assertNumQueries(6, using="other") as captured_queries:
             create_permissions(apps.get_app_config("auth"), verbosity=0, using="other")
-        self.assertIn("INSERT INTO", captured_queries[-1]["sql"].upper())
+        self.assertIn("INSERT_MANY", captured_queries[-1]["sql"].upper())
         self.assertGreater(Permission.objects.using("other").count(), 0)

tests/contenttypes_tests/test_fields.py

@@ -33,7 +33,7 @@ def test_get_object_cache_respects_deleted_objects(self):
 
         post = Post.objects.get(pk=post.pk)
         with self.assertNumQueries(1):
-            self.assertEqual(post.object_id, question_pk)
+            self.assertEqual(post.object_id, str(question_pk))
             self.assertIsNone(post.parent)
             self.assertIsNone(post.parent)
 

tests/contenttypes_tests/urls.py

@@ -2,5 +2,5 @@
 from django.urls import re_path
 
 urlpatterns = [
-    re_path(r"^shortcut/([0-9]+)/(.*)/$", views.shortcut),
+    re_path(r"^shortcut/([\w]+)/(.*)/$", views.shortcut),
 ]

tests/custom_columns/models.py

@@ -15,11 +15,13 @@
 
 """
 
+from django_mongodb.fields import ObjectIdAutoField
+
 from django.db import models
 
 
 class Author(models.Model):
-    Author_ID = models.AutoField(primary_key=True, db_column="Author ID")
+    Author_ID = ObjectIdAutoField(primary_key=True, db_column="Author ID")
     first_name = models.CharField(max_length=30, db_column="firstname")
     last_name = models.CharField(max_length=30, db_column="last")
 
@@ -32,7 +34,7 @@ def __str__(self):
 
 
 class Article(models.Model):
-    Article_ID = models.AutoField(primary_key=True, db_column="Article ID")
+    Article_ID = ObjectIdAutoField(primary_key=True, db_column="Article ID")
     headline = models.CharField(max_length=100)
     authors = models.ManyToManyField(Author, db_table="my_m2m_table")
     primary_author = models.ForeignKey(

tests/file_uploads/tests.py

@@ -9,6 +9,8 @@
 from unittest import mock
 from urllib.parse import quote
 
+from bson import ObjectId
+
 from django.conf import DEFAULT_STORAGE_ALIAS
 from django.core.exceptions import SuspiciousFileOperation
 from django.core.files import temp as tempfile
@@ -740,7 +742,7 @@ def test_filename_case_preservation(self):
             "multipart/form-data; boundary=%(boundary)s" % vars,
         )
         self.assertEqual(response.status_code, 200)
-        id = int(response.content)
+        id = ObjectId(response.content.decode())
         obj = FileModel.objects.get(pk=id)
         # The name of the file uploaded and the file stored in the server-side
         # shouldn't differ.

tests/file_uploads/views.py

@@ -156,7 +156,7 @@ def file_upload_filename_case_view(request):
     file = request.FILES["file_field"]
     obj = FileModel()
     obj.testfile.save(file.name, file)
-    return HttpResponse("%d" % obj.pk)
+    return HttpResponse("%s" % obj.pk)
 
 
 def file_upload_content_type_extra(request):

tests/forms_tests/models.py

@@ -68,7 +68,7 @@ class Meta:
         ordering = ("name",)
 
     def __str__(self):
-        return "ChoiceOption %d" % self.pk
+        return "ChoiceOption %s" % self.pk
 
 
 def choice_default():

tests/generic_relations_regress/tests.py

@@ -251,7 +251,8 @@ def test_annotate(self):
         HasLinkThing.objects.create()
         b = Board.objects.create(name=str(hs1.pk))
         Link.objects.create(content_object=hs2)
-        link = Link.objects.create(content_object=hs1)
+        # An integer PK is required for the Sum() queryset that follows.
+        link = Link.objects.create(content_object=hs1, pk=10)
         Link.objects.create(content_object=b)
         qs = HasLinkThing.objects.annotate(Sum("links")).filter(pk=hs1.pk)
         # If content_type restriction isn't in the query's join condition,
@@ -265,11 +266,11 @@ def test_annotate(self):
         # clear cached results
         qs = qs.all()
         self.assertEqual(qs.count(), 1)
-        # Note - 0 here would be a nicer result...
-        self.assertIs(qs[0].links__sum, None)
+        # Unlike other databases, MongoDB returns 0 instead of null (None).
+        self.assertIs(qs[0].links__sum, 0)
         # Finally test that filtering works.
-        self.assertEqual(qs.filter(links__sum__isnull=True).count(), 1)
-        self.assertEqual(qs.filter(links__sum__isnull=False).count(), 0)
+        self.assertEqual(qs.filter(links__sum__isnull=True).count(), 0)
+        self.assertEqual(qs.filter(links__sum__isnull=False).count(), 1)
 
     def test_filter_targets_related_pk(self):
         # Use hardcoded PKs to ensure different PKs for "link" and "hs2"