[5.1.x] Fixed #36191 -- Truncated the overwritten file content in FileSystemStorage.

Backport of 0d1dd6b from main.

Author: gutard

AUTHORS

@@ -361,6 +361,7 @@ answer newbie questions, and generally made Django that much better:
     Fraser Nevett <[email protected]>
     Gabriel Grant <[email protected]>
     Gabriel Hurley <[email protected]>
+    Gaël Utard
     [email protected]
     Garry Lawrence
     Garry Polley <[email protected]>

django/core/files/storage/filesystem.py

@@ -129,11 +129,11 @@ def _save(self, name, content):
                     )
                     # RemovedInDjango60Warning: when the deprecation ends, replace with:
                     # if self._allow_overwrite:
-                    #     open_flags = open_flags & ~os.O_EXCL
+                    #     open_flags = open_flags & ~os.O_EXCL | os.O_TRUNC
                     if self.OS_OPEN_FLAGS != open_flags:
                         open_flags = self.OS_OPEN_FLAGS
                     elif self._allow_overwrite:
-                        open_flags = open_flags & ~os.O_EXCL
+                        open_flags = open_flags & ~os.O_EXCL | os.O_TRUNC
                     fd = os.open(full_path, open_flags, 0o666)
                     _file = None
                     try:

docs/releases/5.1.7.txt

@@ -12,3 +12,7 @@ Bugfixes
 * Fixed a bug in Django 5.1 where the ``{% querystring %}`` template tag
   returned an empty string rather than ``"?"`` when all parameters had been
   removed from the query string (:ticket:`36182`).
+
+* Fixed a bug in Django 5.1 where ``FileSystemStorage``, with
+  ``allow_overwrite`` set to ``True``, did not truncate the overwritten file
+  content (:ticket:`36191`).

tests/file_storage/tests.py

@@ -704,6 +704,18 @@ def test_save_overwrite_behavior(self):
         finally:
             self.storage.delete(name)
 
+    def test_save_overwrite_behavior_truncate(self):
+        name = "test.file"
+        original_content = b"content extra extra extra"
+        new_smaller_content = b"content"
+        self.storage.save(name, ContentFile(original_content))
+        try:
+            self.storage.save(name, ContentFile(new_smaller_content))
+            with self.storage.open(name) as fp:
+                self.assertEqual(fp.read(), new_smaller_content)
+        finally:
+            self.storage.delete(name)
+
     def test_save_overwrite_behavior_temp_file(self):
         """Saving to same file name twice overwrites the first file."""
         name = "test.file"