Skip to content

Commit d656a46

Browse files
committed
comment out usage of QuerySet.extra()
1 parent 26a57c3 commit d656a46

File tree

1 file changed

+19
-19
lines changed

1 file changed

+19
-19
lines changed

tests/queries/tests.py

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -893,7 +893,7 @@ def test_ticket7235(self):
893893
self.assertSequenceEqual(q.annotate(Count("food")), [])
894894
self.assertSequenceEqual(q.order_by("meal", "food"), [])
895895
self.assertSequenceEqual(q.distinct(), [])
896-
self.assertSequenceEqual(q.extra(select={"foo": "1"}), [])
896+
# self.assertSequenceEqual(q.extra(select={"foo": "1"}), [])
897897
self.assertSequenceEqual(q.reverse(), [])
898898
q.query.low_mark = 1
899899
msg = "Cannot change a query once a slice has been taken."
@@ -1857,27 +1857,27 @@ def test_ordering(self):
18571857

18581858
# Ordering of extra() pieces is possible, too and you can mix extra
18591859
# fields and model fields in the ordering.
1860-
self.assertSequenceEqual(
1861-
Ranking.objects.extra(
1862-
tables=["django_site"], order_by=["-django_site.id", "rank"]
1863-
),
1864-
[self.rank1, self.rank2, self.rank3],
1865-
)
1866-
1867-
sql = "case when %s > 2 then 1 else 0 end" % connection.ops.quote_name("rank")
1868-
qs = Ranking.objects.extra(select={"good": sql})
1869-
self.assertEqual(
1870-
[o.good for o in qs.extra(order_by=("-good",))], [True, False, False]
1871-
)
1872-
self.assertSequenceEqual(
1873-
qs.extra(order_by=("-good", "id")),
1874-
[self.rank3, self.rank2, self.rank1],
1875-
)
1860+
# self.assertSequenceEqual(
1861+
# Ranking.objects.extra(
1862+
# tables=["django_site"], order_by=["-django_site.id", "rank"]
1863+
# ),
1864+
# [self.rank1, self.rank2, self.rank3],
1865+
# )
1866+
1867+
# sql = "case when %s > 2 then 1 else 0 end" % connection.ops.quote_name("rank")
1868+
# qs = Ranking.objects.extra(select={"good": sql})
1869+
# self.assertEqual(
1870+
# [o.good for o in qs.extra(order_by=("-good",))], [True, False, False]
1871+
# )
1872+
# self.assertSequenceEqual(
1873+
# qs.extra(order_by=("-good", "id")),
1874+
# [self.rank3, self.rank2, self.rank1],
1875+
# )
18761876

18771877
# Despite having some extra aliases in the query, we can still omit
18781878
# them in a values() query.
1879-
dicts = qs.values("id", "rank").order_by("id")
1880-
self.assertEqual([d["rank"] for d in dicts], [2, 1, 3])
1879+
# dicts = qs.values("id", "rank").order_by("id")
1880+
# self.assertEqual([d["rank"] for d in dicts], [2, 1, 3])
18811881

18821882
def test_ticket7256(self):
18831883
# An empty values() call includes all aliases, including those from an

0 commit comments

Comments
 (0)