Skip to content

fix: address -Wpessimizing-move warning in binary blob helpers #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: address -Wpessimizing-move warning in binary blob helpers #62

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Contributor

Fixes:

../src/node_main.cc:945:52: warning: moving a temporary object prevents copy elision
    std::vector<char>* str = new std::vector<char>(std::move(GetBoxednodeCodeCacheVector()));
                                                  ^
../src/node_main.cc:945:52: note: remove std::move call here
    std::vector<char>* str = new std::vector<char>(std::move(GetBoxednodeCodeCacheVector()));
                                                  ^~~~~~~~~~                             ~
../src/node_main.cc:986:52: warning: moving a temporary object prevents copy elision
    std::vector<char>* str = new std::vector<char>(std::move(GetBoxednodeSnapshotBlobVector()));
                                                  ^
../src/node_main.cc:986:52: note: remove std::move call here
    std::vector<char>* str = new std::vector<char>(std::move(GetBoxednodeSnapshotBlobVector()));

@addaleax
fix: address -Wpessimizing-move warning in binary blob helpers
fa696e4 
Fixes:

    ../src/node_main.cc:945:52: warning: moving a temporary object prevents copy elision
        std::vector<char>* str = new std::vector<char>(std::move(GetBoxednodeCodeCacheVector()));
                                                      ^
    ../src/node_main.cc:945:52: note: remove std::move call here
        std::vector<char>* str = new std::vector<char>(std::move(GetBoxednodeCodeCacheVector()));
                                                      ^~~~~~~~~~                             ~
    ../src/node_main.cc:986:52: warning: moving a temporary object prevents copy elision
        std::vector<char>* str = new std::vector<char>(std::move(GetBoxednodeSnapshotBlobVector()));
                                                      ^
    ../src/node_main.cc:986:52: note: remove std::move call here
        std::vector<char>* str = new std::vector<char>(std::move(GetBoxednodeSnapshotBlobVector()));
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anemy Anemy Anemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addaleax @Anemy