cleanup code

Author: rueckstiess

src/minicharts/d3fns/date.js

@@ -50,6 +50,7 @@ var minicharts_d3fns_date = function() {
 
   var brush = d3.svg.brush()
     .x(barcodeX)
+    .on('brushstart', brushstart)
     .on('brush', brushed)
     .on('brushend', brushend);
 
@@ -118,6 +119,7 @@ var minicharts_d3fns_date = function() {
     var background = parent.find('g.brush > rect.background')[0];
     var brushNode = parent.find('g.brush')[0];
     var start = barcodeX.invert(d3.mouse(background)[0]);
+    brushstart.call(brushNode, line);
 
     var w = d3.select(window)
       .on('mousemove', mousemove)
@@ -167,7 +169,9 @@ var minicharts_d3fns_date = function() {
       var upperBarBottom = innerHeight / 2 - 20;
 
       barcodeX
-        .domain(d3.extent(values, function(d) { return d.ts; }))
+        .domain(d3.extent(values, function(d) {
+          return d.ts;
+        }))
         .range([0, innerWidth]);
 
       // group by weekdays
@@ -210,27 +214,27 @@ var minicharts_d3fns_date = function() {
       gEnter.append('g')
         .attr('class', 'weekday')
         .append('text')
-          .attr('class', 'date-icon fa-fw')
-          .attr('x', 0)
-          .attr('dx', '-0.6em')
-          .attr('y', 0)
-          .attr('dy', '1em')
-          .attr('text-anchor', 'end')
-          .attr('font-family', 'FontAwesome')
-          .text('\uf133');
+        .attr('class', 'date-icon fa-fw')
+        .attr('x', 0)
+        .attr('dx', '-0.6em')
+        .attr('y', 0)
+        .attr('dy', '1em')
+        .attr('text-anchor', 'end')
+        .attr('font-family', 'FontAwesome')
+        .text('\uf133');
 
       gEnter.append('g')
         .attr('class', 'hour')
         .attr('transform', 'translate(' + (width / (upperRatio + 1) + upperMargin) + ', 0)')
         .append('text')
-          .attr('class', 'date-icon fa-fw')
-          .attr('x', 0)
-          .attr('dx', '-0.6em')
-          .attr('y', 0)
-          .attr('dy', '1em')
-          .attr('text-anchor', 'end')
-          .attr('font-family', 'FontAwesome')
-          .text('\uf017');
+        .attr('class', 'date-icon fa-fw')
+        .attr('x', 0)
+        .attr('dx', '-0.6em')
+        .attr('y', 0)
+        .attr('dy', '1em')
+        .attr('text-anchor', 'end')
+        .attr('font-family', 'FontAwesome')
+        .text('\uf017');
 
       var gBrush = g.selectAll('.brush').data([0]);
       gBrush.enter().append('g')
@@ -251,8 +255,8 @@ var minicharts_d3fns_date = function() {
         .on('mouseout', tip.hide)
         .on('mousedown', handleMouseDown);
 
-        // disabling direct onClick handler in favor of click-drag
-        // .on('click', handleClick);
+      // disabling direct onClick handler in favor of click-drag
+      // .on('click', handleClick);
 
       lines
         .attr('y1', barcodeTop)

src/minicharts/d3fns/many.js

@@ -16,7 +16,7 @@ var minicharts_d3fns_many = function() {
     bgbars: false,
     scale: false,
     labels: false, // label defaults will be set further below
-    selectable: true  // setting to false disables query builder for this chart
+    selectable: true // setting to false disables query builder for this chart
   };
 
   var xScale = d3.scale.ordinal();

src/minicharts/querybuilder.js

@@ -317,7 +317,7 @@ module.exports = {
         } else if (message.dx === 0) {
           // handle non-binned ranges
           mustSelect = checkBounds[message.lowerOp](d.value, message.selected[0])
-                    && checkBounds[message.upperOp](d.value, message.selected[1]);
+            && checkBounds[message.upperOp](d.value, message.selected[1]);
         } else {
           // handle binned ranges
           var halfSelect = false;

src/minicharts/viz.js

@@ -2,7 +2,7 @@ var AmpersandView = require('ampersand-view');
 var _ = require('lodash');
 var $ = require('jquery');
 var d3 = require('d3');
-var debug = require('debug')('scout:minicharts:viz');
+// var debug = require('debug')('scout:minicharts:viz');
 
 var VizView = AmpersandView.extend({
   _values: {},

src/models/editable-query.js

@@ -2,7 +2,6 @@ var Model = require('ampersand-model');
 var EJSON = require('mongodb-extended-json');
 var Query = require('mongodb-language-model').Query;
 var _ = require('lodash');
-
 // var debug = require('debug')('scout:models:editable-query');
 
 /**
@@ -45,10 +44,10 @@ module.exports = Model.extend({
     //     // return the string without key quotes for display in RefineBarView
     //   }
     // },
+    /*eslint no-new: 0*/
     valid: {
       deps: ['cleanString'],
       fn: function() {
-        /*eslint no-new: 0*/
         try {
           // is it valid eJSON?
           var parsed = EJSON.parse(this.cleanString);

src/refine-view/index.js

@@ -3,7 +3,7 @@ var EditableQuery = require('../models/editable-query');
 var $ = require('jquery');
 var EJSON = require('mongodb-extended-json');
 var Query = require('mongodb-language-model').Query;
-var debug = require('debug')('scout:refine-view:index');
+// var debug = require('debug')('scout:refine-view:index');
 
 module.exports = AmpersandView.extend({
   template: require('./index.jade'),