chore: minimize side effects from scroll to override

Author: gagik

packages/compass-assistant/src/assistant-chat.spec.tsx

@@ -7,18 +7,22 @@ import {
 } from '@mongodb-js/testing-library-compass';
 import { AssistantChat } from './assistant-chat';
 import { expect } from 'chai';
-import { createMockChat } from '../test/utils';
+import { createMockChat, withMockedScrollTo } from '../test/utils';
 import type { AssistantMessage } from './compass-assistant-provider';
 
 describe('AssistantChat', function () {
+  withMockedScrollTo();
+
+  let originalScrollTo: typeof Element.prototype.scrollTo;
   // Mock scrollTo method for DOM elements to prevent test failures
   before(function () {
-    if (!Element.prototype.scrollTo) {
-      Element.prototype.scrollTo = function () {
-        // No-op implementation for testing
-      };
-    }
+    originalScrollTo = Element.prototype.scrollTo.bind(Element.prototype);
+    Element.prototype.scrollTo = () => {};
+  });
+  after(function () {
+    Element.prototype.scrollTo = originalScrollTo;
   });
+
   const mockMessages: AssistantMessage[] = [
     {
       id: 'user',

packages/compass-assistant/src/compass-assistant-provider.spec.tsx

@@ -22,7 +22,7 @@ import {
 } from '@mongodb-js/compass-components';
 import type { AtlasService } from '@mongodb-js/atlas-service/provider';
 import { CompassAssistantDrawer } from './compass-assistant-drawer';
-import { createMockChat } from '../test/utils';
+import { createMockChat, withMockedScrollTo } from '../test/utils';
 
 // Test component that renders AssistantProvider with children
 const TestComponent: React.FunctionComponent<{
@@ -85,6 +85,7 @@ describe('AssistantProvider', function () {
   });
 
   describe('with existing chat instance', function () {
+    withMockedScrollTo();
     before(function () {
       // TODO(COMPASS-9618): skip in electron runtime for now, drawer has issues rendering
       if ((process as any).type === 'renderer') {
@@ -117,7 +118,7 @@ describe('AssistantProvider', function () {
       );
 
       expect(screen.getByTestId('assistant-message-2')).to.exist;
-      expect(screen.getByTestId('assistant-message-2')).to.have.text(
+      expect(screen.getByTestId('assistant-message-2')).to.contain.text(
         'Test assistant message'
       );
     });

packages/compass-assistant/test/utils.tsx

@@ -15,3 +15,17 @@ export const createMockChat = ({
     sendMessage: sinon.SinonStub;
   };
 };
+
+export function withMockedScrollTo() {
+  let originalScrollTo: typeof Element.prototype.scrollTo;
+  // Mock scrollTo method for DOM elements to prevent test failures
+  before(function () {
+    originalScrollTo = Element.prototype.scrollTo;
+    if (!Element.prototype.scrollTo) {
+      Element.prototype.scrollTo = () => {};
+    }
+  });
+  after(function () {
+    Element.prototype.scrollTo = originalScrollTo;
+  });
+}