Skip to content

Commit 031dca3

Browse files
what happens if i dummy marketing modal
1 parent 022736f commit 031dca3

File tree

2 files changed

+41
-41
lines changed

2 files changed

+41
-41
lines changed

packages/compass-e2e-tests/tests/no-network-traffic.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ describe('networkTraffic: false / Isolated Edition', function () {
5757
const wrapperFile = path.join(tmpdir, 'wrap.sh');
5858
let str;
5959
if (process.platform === 'linux') {
60-
str = `#!/bin/bash\nulimit -c 0; exec strace -f -e connect -qqq -o '${outfile}' '${binary}' "$@"\n`;
60+
str = `#!/bin/bash\nulimit -c 0; exec strace -f -e connect -t -o '${outfile}' '${binary}' "$@"\n`;
6161
} else {
6262
str = `#!/bin/bash\nulimit -c 0; '${binary}' "$@"\n`;
6363
}
@@ -73,7 +73,7 @@ describe('networkTraffic: false / Isolated Edition', function () {
7373
wrapBinary,
7474
// TODO(COMPASS-8166): firstRun: true seems to result in network traffic.
7575
// Probably the welcome modal.
76-
firstRun: true,
76+
firstRun: false,
7777
});
7878
const browser = compass.browser;
7979

packages/compass-welcome/src/components/modal.tsx

Lines changed: 39 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -40,45 +40,45 @@ export const WelcomeModal: React.FunctionComponent<WelcomeModalProps> = ({
4040
closeModal();
4141
}, [closeModal]);
4242

43-
return (
44-
<MarketingModal
45-
data-testid="welcome-modal"
46-
open={isOpen}
47-
onClose={close}
48-
onButtonClick={close}
49-
title="Welcome to Compass"
50-
buttonText="Start"
51-
showBlob
52-
blobPosition="top right"
53-
disclaimer={
54-
networkTraffic ? (
55-
<div className={disclaimer}>
56-
To help improve our products, anonymous usage data is collected and
57-
sent to MongoDB in accordance with MongoDB&apos;s privacy policy.
58-
<br />
59-
Manage this behaviour on the Compass{' '}
60-
<Link
61-
data-testid="open-settings-link"
62-
hideExternalIcon
63-
className={link}
64-
onClick={goToSettings}
65-
>
66-
Settings
67-
</Link>{' '}
68-
page.
69-
</div>
70-
) : undefined
71-
}
72-
graphic={<WelcomeModalImage width={156} height={209} />}
73-
linkText={''}
74-
darkMode={darkMode}
75-
>
76-
<Body>
77-
Build aggregation pipelines, optimize queries, analyze schemas,
78-
and&nbsp;more. All with the GUI built by - and for - MongoDB.
79-
</Body>
80-
</MarketingModal>
81-
);
43+
return <div>hello</div>;
44+
// <MarketingModal
45+
// data-testid="welcome-modal"
46+
// open={isOpen}
47+
// onClose={close}
48+
// onButtonClick={close}
49+
// title="Welcome to Compass"
50+
// buttonText="Start"
51+
// showBlob
52+
// blobPosition="top right"
53+
// disclaimer={
54+
// networkTraffic ? (
55+
// <div className={disclaimer}>
56+
// To help improve our products, anonymous usage data is collected and
57+
// sent to MongoDB in accordance with MongoDB&apos;s privacy policy.
58+
// <br />
59+
// Manage this behaviour on the Compass{' '}
60+
// <Link
61+
// data-testid="open-settings-link"
62+
// hideExternalIcon
63+
// className={link}
64+
// onClick={goToSettings}
65+
// >
66+
// Settings
67+
// </Link>{' '}
68+
// page.
69+
// </div>
70+
// ) : undefined
71+
// }
72+
// graphic={<WelcomeModalImage width={156} height={209} />}
73+
// linkText={''}
74+
// darkMode={darkMode}
75+
// >
76+
// <Body>
77+
// Build aggregation pipelines, optimize queries, analyze schemas,
78+
// and&nbsp;more. All with the GUI built by - and for - MongoDB.
79+
// </Body>
80+
// </MarketingModal>
81+
// );
8282
};
8383

8484
export default withPreferences(WelcomeModal, ['networkTraffic']);

0 commit comments

Comments
 (0)