chore(eslint-config): re-enable no-unsafe-declaration-merging rule

Author: gribnoysup

configs/eslint-config-compass/index.js

@@ -27,7 +27,6 @@ const extraTsRules = {
   '@typescript-eslint/no-base-to-string': 'warn',
   '@typescript-eslint/unbound-method': 'warn',
   '@typescript-eslint/no-duplicate-type-constituents': 'warn',
-  '@typescript-eslint/no-unsafe-declaration-merging': 'warn',
 };
 
 const tsRules = {

packages/compass-components/src/components/guide-cue/guide-cue-service.ts

@@ -16,29 +16,14 @@ export type ShowCueEventDetail = CustomEvent<{
   groupId?: GroupName;
 }>;
 
+type CustomEventListenerOrEventListenerObject<E> =
+  | { handleEvent: (evt: E) => void }
+  | ((evt: E) => void);
+
 interface GuideCueEventMap {
   'show-cue': ShowCueEventDetail;
 }
 
-export interface GuideCueService extends EventTarget {
-  addEventListener<K extends keyof GuideCueEventMap>(
-    type: K,
-    listener: (this: GuideCueEventMap, ev: GuideCueEventMap[K]) => void
-  ): void;
-  addEventListener(
-    type: string,
-    listener: EventListenerOrEventListenerObject
-  ): void;
-  removeEventListener<K extends keyof GuideCueEventMap>(
-    type: K,
-    listener: (this: GuideCueEventMap, ev: GuideCueEventMap[K]) => void
-  ): void;
-  removeEventListener(
-    type: string,
-    listener: EventListenerOrEventListenerObject
-  ): void;
-}
-
 export type Cue = {
   groupId?: GroupName;
   step: number;
@@ -261,6 +246,30 @@ export class GuideCueService extends EventTarget {
       return this.onNext();
     }
   }
+
+  addEventListener<K extends keyof GuideCueEventMap>(
+    type: K,
+    listener: CustomEventListenerOrEventListenerObject<
+      GuideCueEventMap[K]
+    > | null
+  ): void {
+    return super.addEventListener(
+      type,
+      listener as EventListenerOrEventListenerObject
+    );
+  }
+
+  removeEventListener<K extends keyof GuideCueEventMap>(
+    type: K,
+    listener: CustomEventListenerOrEventListenerObject<
+      GuideCueEventMap[K]
+    > | null
+  ): void {
+    return super.removeEventListener(
+      type,
+      listener as EventListenerOrEventListenerObject
+    );
+  }
 }
 
 export const guideCueService = new GuideCueService(