use nan

Author: paula-stacho

packages/compass-data-modeling/src/components/diagram-editor.spec.tsx

@@ -91,14 +91,14 @@ const storageItems: MongoDBDataModelDescription[] = [
             {
               ns: 'db1.collection1',
               indexes: [],
-              displayPosition: [-1, -1],
+              displayPosition: [NaN, NaN],
               shardKey: {},
               jsonSchema: { bsonType: 'object' },
             },
             {
               ns: 'db1.collection2',
               indexes: [],
-              displayPosition: [-1, -1],
+              displayPosition: [NaN, NaN],
               shardKey: {},
               jsonSchema: { bsonType: 'object' },
             },

packages/compass-data-modeling/src/components/diagram-editor.tsx

@@ -267,7 +267,7 @@ const DiagramEditor: React.FunctionComponent<{
   useEffect(() => {
     if (nodes.length === 0) return;
     const isInitialState = nodes.every(
-      (node) => node.position.x === -1 && node.position.y === -1
+      (node) => isNaN(node.position.x) || isNaN(node.position.y)
     );
     if (isInitialState) {
       void applyInitialLayout();

packages/compass-data-modeling/src/store/diagram.spec.ts

@@ -97,12 +97,12 @@ describe('Data Modeling store', function () {
       expect(initialEdit.model.collections[0]).to.deep.include({
         ns: newDiagram.collections[0].ns,
         jsonSchema: newDiagram.collections[0].schema,
-        displayPosition: [-1, -1],
+        displayPosition: [NaN, NaN],
       });
       expect(initialEdit.model.collections[1]).to.deep.include({
         ns: newDiagram.collections[1].ns,
         jsonSchema: newDiagram.collections[1].schema,
-        displayPosition: [-1, -1],
+        displayPosition: [NaN, NaN],
       });
       expect(initialEdit.model.relationships).to.deep.equal(
         newDiagram.relations

packages/compass-data-modeling/src/store/diagram.ts

@@ -133,10 +133,10 @@ export const diagramReducer: Reducer<DiagramState> = (
               collections: action.collections.map((collection) => ({
                 ns: collection.ns,
                 jsonSchema: collection.schema,
+                displayPosition: [NaN, NaN],
                 // TODO
                 indexes: [],
                 shardKey: undefined,
-                displayPosition: [-1, -1],
               })),
               relationships: action.relations,
             },
@@ -175,7 +175,7 @@ export const diagramReducer: Reducer<DiagramState> = (
               ...initialEdit.model,
               collections: initialEdit.model.collections.map((collection) => ({
                 ...collection,
-                displayPosition: action.positions[collection.ns] || [-1, -1],
+                displayPosition: action.positions[collection.ns] || [NaN, NaN],
               })),
             },
           },