no need to fret about the correct filename

Author: lerouxb

packages/compass-smoke-tests/src/cli.ts

@@ -16,6 +16,7 @@ import {
 import { createSandbox } from './directories';
 import { downloadFile } from './downloads';
 import { type PackageKind, SUPPORTED_PACKAGES } from './packages';
+import { getLatestRelease } from './releases';
 import { type SmokeTestsContext } from './context';
 import { installMacZIP } from './installers/mac-zip';
 
@@ -145,60 +146,6 @@ async function getTestSubject(
   }
 }
 
-type Arch = 'arm64' | 'x64';
-
-type PlatformShortName =
-  | 'darwin-arm64'
-  | 'darwin-x64'
-  | 'windows'
-  | 'linux_deb'
-  | 'linux_rpm';
-
-function getPlatformShortName(
-  arch: Arch,
-  kind: PackageKind
-): PlatformShortName {
-  if (arch === 'arm64') {
-    if (kind === 'osx_dmg' || kind === 'osx_zip') {
-      return 'darwin-arm64';
-    }
-  }
-  if (arch === 'x64') {
-    if (kind === 'osx_dmg' || kind === 'osx_zip') {
-      return 'darwin-x64';
-    }
-    if (
-      kind === 'windows_setup' ||
-      kind === 'windows_msi' ||
-      kind === 'windows_zip'
-    ) {
-      return 'windows';
-    }
-    if (kind === 'linux_deb' || kind === 'linux_tar') {
-      return 'linux_deb';
-    }
-    if (kind === 'linux_rpm' || kind === 'rhel_tar') {
-      return 'linux_rpm';
-    }
-  }
-
-  throw new Error(`Unsupported arch/kind combo: ${arch}/${kind}`);
-}
-
-async function getLatestRelease(
-  channel: 'dev' | 'beta' | 'stable',
-  arch: Arch,
-  kind: PackageKind,
-  forceDownload?: boolean
-): Promise<string> {
-  const shortName = getPlatformShortName(arch, kind);
-
-  return await downloadFile({
-    url: `http://compass.mongodb.com/api/v2/download/latest/compass/${channel}/${shortName}`,
-    clearCache: forceDownload,
-  });
-}
-
 function getInstaller(kind: PackageKind) {
   if (kind === 'osx_dmg') {
     return installMacDMG;

packages/compass-smoke-tests/src/downloads.ts

@@ -7,7 +7,7 @@ import { ensureDownloadsDirectory } from './directories';
 
 type DownloadFileOptions = {
   url: string;
-  targetFilename?: string;
+  targetFilename: string;
   clearCache?: boolean;
 };
 
@@ -18,14 +18,6 @@ export async function downloadFile({
 }: DownloadFileOptions): Promise<string> {
   const response = await fetch(url);
 
-  if (!targetFilename) {
-    // if no filename was specified, work out the filename based on the final
-    // URL the way a browser would
-    targetFilename = path.basename(new URL(response.url).pathname);
-  }
-
-  assert(targetFilename, 'Expected a filename');
-
   const etag = response.headers.get('etag');
   assert(etag, 'Expected an ETag header');
   const cleanEtag = etag.match(/[0-9a-fA-F]/g)?.join('');

packages/compass-smoke-tests/src/releases.ts

@@ -0,0 +1,91 @@
+import { downloadFile } from './downloads';
+import { type PackageKind } from './packages';
+
+type Arch = 'arm64' | 'x64';
+
+type PlatformShortName =
+  | 'darwin-arm64'
+  | 'darwin-x64'
+  | 'windows'
+  | 'linux_deb'
+  | 'linux_rpm';
+
+function getPlatformShortName(
+  arch: Arch,
+  kind: PackageKind
+): PlatformShortName {
+  if (arch === 'arm64') {
+    if (kind === 'osx_dmg' || kind === 'osx_zip') {
+      return 'darwin-arm64';
+    }
+  }
+  if (arch === 'x64') {
+    if (kind === 'osx_dmg' || kind === 'osx_zip') {
+      return 'darwin-x64';
+    }
+    if (
+      kind === 'windows_setup' ||
+      kind === 'windows_msi' ||
+      kind === 'windows_zip'
+    ) {
+      return 'windows';
+    }
+    if (kind === 'linux_deb' || kind === 'linux_tar') {
+      return 'linux_deb';
+    }
+    if (kind === 'linux_rpm' || kind === 'rhel_tar') {
+      return 'linux_rpm';
+    }
+  }
+
+  throw new Error(`Unsupported arch/kind combo: ${arch}/${kind}`);
+}
+
+type PlatformExtension = 'dmg' | 'exe' | 'deb' | 'rpm';
+
+function getPlatformExtension(
+  arch: Arch,
+  kind: PackageKind
+): PlatformExtension {
+  if (arch === 'arm64') {
+    if (kind === 'osx_dmg' || kind === 'osx_zip') {
+      return 'dmg';
+    }
+  }
+  if (arch === 'x64') {
+    if (kind === 'osx_dmg' || kind === 'osx_zip') {
+      return 'dmg';
+    }
+    if (
+      kind === 'windows_setup' ||
+      kind === 'windows_msi' ||
+      kind === 'windows_zip'
+    ) {
+      return 'exe';
+    }
+    if (kind === 'linux_deb' || kind === 'linux_tar') {
+      return 'deb';
+    }
+    if (kind === 'linux_rpm' || kind === 'rhel_tar') {
+      return 'rpm';
+    }
+  }
+
+  throw new Error(`Unsupported arch/kind combo: ${arch}/${kind}`);
+}
+
+export async function getLatestRelease(
+  channel: 'dev' | 'beta' | 'stable',
+  arch: Arch,
+  kind: PackageKind,
+  forceDownload?: boolean
+): Promise<string> {
+  const shortName = getPlatformShortName(arch, kind);
+  const extension = getPlatformExtension(arch, kind);
+
+  return await downloadFile({
+    url: `http://compass.mongodb.com/api/v2/download/latest/compass/${channel}/${shortName}`,
+    targetFilename: `latest-${channel}.${extension}`,
+    clearCache: forceDownload,
+  });
+}