Skip to content

Commit 09b13ca

Browse files
committed
bump the timeout where we wait for the update to finish downloading
1 parent f493f3c commit 09b13ca

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

packages/compass-e2e-tests/helpers/test-runner-context.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ function buildCommonArgs(yargs: Argv) {
5151
description: 'Set a custom default mocha timeout',
5252
// Kinda arbitrary, but longer than webdriver-waitfor-timeout so the test
5353
// can fail before Mocha times out
54-
default: 240_000,
54+
default: 300_000, // 5 minutes
5555
})
5656
.option('mocha-bail', {
5757
type: 'boolean',

packages/compass-e2e-tests/tests/auto-update.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,10 @@ describe('Auto-update', function () {
3131

3232
if (process.env.AUTO_UPDATE_UPDATABLE === 'true') {
3333
const restartButton = browser.$(Selectors.AutoUpdateRestartButton);
34-
await restartButton.waitForDisplayed();
34+
// 2 minutes is apparently not always enough for downloading the
35+
// windows update on GHA. Has to be shorter than the mocha test
36+
// timeout so this can fail before the test does.
37+
await restartButton.waitForDisplayed({ timeout: 240_000 });
3538

3639
if (process.env.EXPECTED_UPDATE_VERSION) {
3740
expect(

0 commit comments

Comments
 (0)