Skip to content

Commit 0c958ed

Browse files
committed
fixup: remove e2e test compass web preference setting, lets do that in a different pr
1 parent 7537e4d commit 0c958ed

File tree

2 files changed

+15
-26
lines changed

2 files changed

+15
-26
lines changed

packages/compass-e2e-tests/helpers/commands/set-feature.ts

Lines changed: 15 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -11,31 +11,21 @@ export async function setFeature<K extends keyof UserPreferences>(
1111
value: UserPreferences[K]
1212
): Promise<void> {
1313
if (isTestingWeb()) {
14-
await browser.waitUntil(async function () {
15-
// When running in Compass web we cannot use the IPC to update the
16-
// preferences so we use a global function.
17-
const didSavePreference = await browser.execute(
18-
async (_name, _value) => {
19-
if (!(globalThis as any).__compassWebE2ETestSavePreferences) {
20-
return false;
21-
}
22-
23-
const attributes: Partial<AllPreferences> = {
24-
[_name]: _value === null ? undefined : _value,
25-
};
26-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
27-
await (globalThis as any).__compassWebE2ETestSavePreferences(
28-
attributes
29-
);
30-
31-
return true;
32-
},
33-
name,
34-
value
35-
);
36-
37-
return didSavePreference;
38-
});
14+
// When running in Compass web we cannot use the IPC to update the
15+
// preferences so we use a global function.
16+
await browser.execute(
17+
async (_name, _value) => {
18+
const attributes: Partial<AllPreferences> = {
19+
[_name]: _value === null ? undefined : _value,
20+
};
21+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
22+
await (globalThis as any).__compassWebE2ETestSavePreferences(
23+
attributes
24+
);
25+
},
26+
name,
27+
value
28+
);
3929
return;
4030
}
4131

packages/compass-e2e-tests/tests/collection-schema-tab.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,6 @@ describe('Collection schema tab', function () {
135135

136136
const exportSchemaContent = browser.$(Selectors.ExportSchemaOutput);
137137
await exportSchemaContent.waitForDisplayed();
138-
139138
const text = await browser.getCodemirrorEditorText(
140139
Selectors.ExportSchemaOutput
141140
);

0 commit comments

Comments
 (0)