chore(compass-aggregations): adapt CreateViewPlugin to work with dynamically provided connectionId for supporting multiple connections COMPASS-7861 (#5755)

Author: himanshusinghs

packages/compass-aggregations/src/components/create-view-modal/create-view-modal.tsx

@@ -9,11 +9,7 @@ import {
   spacing,
   TextInput,
 } from '@mongodb-js/compass-components';
-import {
-  createView,
-  changeViewName,
-  toggleIsVisible,
-} from '../../modules/create-view';
+import { createView, changeViewName, close } from '../../modules/create-view';
 import type { LoggerAndTelemetry } from '@mongodb-js/compass-logging/provider';
 import { withLoggerAndTelemetry } from '@mongodb-js/compass-logging/provider';
 import type { CreateViewRootState } from '../../stores/create-view';
@@ -27,7 +23,7 @@ const progressContainerStyles = css({
 type CreateViewModalProps = {
   createView: () => void;
   isVisible?: boolean;
-  toggleIsVisible: (newVal: boolean) => void;
+  closeModal: () => void;
   name?: string;
   changeViewName: (name: string) => void;
   isDuplicating?: boolean;
@@ -63,7 +59,7 @@ class CreateViewModal extends PureComponent<CreateViewModalProps> {
   };
 
   onCancel = () => {
-    this.props.toggleIsVisible(false);
+    this.props.closeModal();
   };
 
   /**
@@ -121,7 +117,7 @@ const MappedCreateViewModal = withLoggerAndTelemetry(
   connect(mapStateToProps, {
     createView,
     changeViewName,
-    toggleIsVisible,
+    closeModal: close,
   })(CreateViewModal),
   'COMPASS-CREATE-VIEW-UI'
 );

packages/compass-aggregations/src/index.ts

@@ -7,6 +7,7 @@ import StageEditor from './components/stage-editor';
 import CreateViewModal from './components/create-view-modal';
 import {
   connectionInfoAccessLocator,
+  connectionsManagerLocator,
   dataServiceLocator,
   type DataServiceLocator,
 } from '@mongodb-js/compass-connections/provider';
@@ -60,10 +61,9 @@ export const CreateViewPlugin = registerHadronPlugin(
     activate: activateCreateViewPlugin,
   },
   {
-    dataService: dataServiceLocator as DataServiceLocator<'createView'>,
+    connectionsManager: connectionsManagerLocator,
     logger: createLoggerAndTelemetryLocator('COMPASS-CREATE-VIEW-UI'),
     workspaces: workspacesServiceLocator,
-    connectionInfoAccess: connectionInfoAccessLocator,
   }
 );
 

packages/compass-aggregations/src/modules/create-view/index.spec.ts

@@ -1,16 +1,77 @@
-import reducer, { INITIAL_STATE, reset } from './';
+import reducer, {
+  INITIAL_STATE,
+  reset,
+  open,
+  close,
+  toggleIsRunning,
+  handleError,
+  clearError,
+  changeViewName,
+} from './';
 import { expect } from 'chai';
 
 describe('create view module', function () {
-  describe('#reducer', function () {
-    describe('when an action is provided', function () {
-      describe('when the action is reset', function () {
-        it('returns the reset state', function () {
-          expect(reducer(INITIAL_STATE, reset())).to.deep.equal({
-            ...INITIAL_STATE,
-          });
-        });
-      });
+  it('handles the open and close actions', function () {
+    const stateAfterOpen = reducer(
+      INITIAL_STATE,
+      open({
+        connectionId: 'TEST',
+        sourceNs: 'test.coll',
+        sourcePipeline: [],
+        duplicate: true,
+      })
+    );
+    expect(stateAfterOpen).to.deep.equal({
+      ...INITIAL_STATE,
+      connectionId: 'TEST',
+      isRunning: false,
+      isVisible: true,
+      isDuplicating: true,
+      name: '',
+      source: 'test.coll',
+      pipeline: [],
+    });
+
+    expect(reducer(stateAfterOpen, close())).to.deep.equal(INITIAL_STATE);
+  });
+
+  it('handles the reset action', function () {
+    const isRunningState = reducer(INITIAL_STATE, toggleIsRunning(true));
+    expect(reducer(isRunningState, reset())).to.deep.equal({
+      ...INITIAL_STATE,
+    });
+  });
+
+  it('handles the toggleIsRunning action', function () {
+    const isRunningState = reducer(INITIAL_STATE, toggleIsRunning(true));
+    expect(isRunningState).to.deep.equal({
+      ...INITIAL_STATE,
+      isRunning: true,
+    });
+    expect(reducer(isRunningState, toggleIsRunning(false))).to.deep.equal({
+      ...isRunningState,
+      isRunning: false,
+    });
+  });
+
+  it('handles the handleError and clearError actions', function () {
+    const err = new Error('Oops!');
+    const erroredState = reducer(INITIAL_STATE, handleError(err));
+    expect(erroredState).to.deep.equal({
+      ...INITIAL_STATE,
+      error: err,
+    });
+
+    expect(reducer(erroredState, clearError())).to.deep.equal({
+      ...erroredState,
+      error: null,
+    });
+  });
+
+  it('handles the changeViewName action', function () {
+    expect(reducer(INITIAL_STATE, changeViewName('Yikes'))).to.deep.equal({
+      ...INITIAL_STATE,
+      name: 'Yikes',
     });
   });
 });