fixup: compute shell version via evaluate("version()")

Author: addaleax

packages/compass-shell/src/components/compass-shell/tab-compass-shell.tsx

@@ -21,6 +21,7 @@ import { usePreference } from 'compass-preferences-model/provider';
 import { Shell } from '@mongosh/browser-repl';
 import type { RootState } from '../../stores/store';
 import { selectRuntimeById, saveHistory } from '../../stores/store';
+import { useLogger } from '@mongodb-js/compass-logging/provider';
 
 const compassShellStyles = css(
   {
@@ -74,6 +75,8 @@ function useInitialEval(
   return initialEvalApplied ? undefined : initialEvaluate;
 }
 
+let _mongoshVersion = '';
+
 export const CompassShell: React.FC<CompassShellProps> = ({
   runtime,
   initialHistory,
@@ -105,6 +108,33 @@ export const CompassShell: React.FC<CompassShellProps> = ({
     initialInput ?? ''
   );
 
+  const [mongoshVersion, setMongoshVersion] = useTabState(
+    'mongoshVersion',
+    _mongoshVersion
+  );
+  const logger = useLogger('COMPASS-SHELL');
+
+  useEffect(() => {
+    const { log, mongoLogId } = logger;
+    if (!runtime || mongoshVersion) return;
+    runtime
+      .evaluate('version()')
+      .then((value) => {
+        setMongoshVersion((_mongoshVersion = 'v' + String(value.printable)));
+      })
+      .catch((err) => {
+        setMongoshVersion('[unknown]');
+        log.error(
+          mongoLogId(1_001_000_342),
+          'shell',
+          'could not evaluate mongosh version',
+          {
+            error: (err as Error).message,
+          }
+        );
+      });
+  }, [runtime, logger, mongoshVersion, setMongoshVersion]);
+
   useOnTabReplace(() => {
     // Never allow to replace the shell tab to avoid destroying the runtime
     // unnecessarily
@@ -156,13 +186,17 @@ export const CompassShell: React.FC<CompassShellProps> = ({
     );
   }
 
-  if (!canRenderShell) {
+  if (!canRenderShell || !mongoshVersion) {
     return <div className={compassShellStyles} />;
   }
 
   return (
     <>
-      <ShellInfoModal show={infoModalVisible} hideInfoModal={hideInfoModal} />
+      <ShellInfoModal
+        show={infoModalVisible}
+        hideInfoModal={hideInfoModal}
+        mongoshVersion={mongoshVersion}
+      />
       {/* Clicking on the shell container to focus it is a ux improvement to give
           the shell more of a native shell feeling. We disable the jsx-ally rules
           as this is a unique ux improvement solely for clicking. */}

packages/compass-shell/src/components/shell-info-modal/shell-info-modal.spec.tsx

@@ -8,7 +8,9 @@ describe('InfoModal [Component]', function () {
   let component;
 
   beforeEach(function () {
-    component = mount(<ShellInfoModal show hideInfoModal={() => {}} />);
+    component = mount(
+      <ShellInfoModal show hideInfoModal={() => {}} mongoshVersion="v2.3.456" />
+    );
   });
 
   afterEach(function () {

packages/compass-shell/src/components/shell-info-modal/shell-info-modal.tsx

@@ -14,11 +14,6 @@ import {
   type TrackFunction,
 } from '@mongodb-js/compass-telemetry/provider';
 
-const mongoshVersion = `v${
-  // eslint-disable-next-line @typescript-eslint/restrict-template-expressions, @typescript-eslint/no-var-requires
-  require('@mongosh/browser-repl/package.json').version
-}`;
-
 const shortcutsTableContainerStyles = css({
   marginTop: spacing[2],
   maxHeight: '50vh',
@@ -32,9 +27,11 @@ const shortcutsTitleStyles = css({
 function ShellInfoModal({
   hideInfoModal,
   show,
+  mongoshVersion,
 }: {
   hideInfoModal: () => void;
   show: boolean;
+  mongoshVersion: string;
 }) {
   useTrackOnChange(
     (track: TrackFunction) => {

packages/compass-shell/src/plugin.tsx

@@ -62,6 +62,7 @@ export function onActivated(
           createAndStoreRuntime(dataService, logger, track, connectionInfo).id
         : null,
       history: null,
+      mongoshVersion: '',
     },
     applyMiddleware(
       thunk.withExtraArgument({