chore(data-service): log maxTimeMS along with find(), aggregate() and estimatedCount(), always set a default maxTimeMS COMPASS-7747 (#5630)

* log maxTimeMS along with find() and aggregate()

* make sure we always set a maxTimeMS for estimatedCount

* reduce the default maxTimeMS for estimatedCount

Author: lerouxb

packages/compass-aggregations/src/modules/input-documents.ts

@@ -122,14 +122,23 @@ export const refreshInputDocuments = (): PipelineBuilderThunkAction<
         | undefined,
     };
 
+    // maxTimeMS defaults to null here because the aggregation options field's
+    // maxTimeMS defaults to empty and the preference defaults to undefined.
+    // We need a timeout on count because for timeseries estimatedCount() seems
+    // to just do a colscan and we need that timeout to be low compared to the
+    // aggregation one anyway. For aggregations it is less critical because we
+    // $limit to the first few records.
+    const countOptions = { ...options, maxTimeMS: 500 };
+    const aggregateOptions = { ...options };
+
     const exampleDocumentsPipeline = [{ $limit: sampleSize }];
 
     dispatch(loadingInputDocuments());
 
     try {
       const data = await Promise.allSettled([
-        dataService.estimatedCount(ns, options),
-        dataService.aggregate(ns, exampleDocumentsPipeline, options),
+        dataService.estimatedCount(ns, countOptions),
+        dataService.aggregate(ns, exampleDocumentsPipeline, aggregateOptions),
       ]);
 
       const count = data[0].status === 'fulfilled' ? data[0].value : null;

packages/data-service/src/data-service.ts

@@ -1497,16 +1497,20 @@ class DataServiceImpl extends WithLogContext implements DataService {
     }
   }
 
-  @op(mongoLogId(1_001_000_034))
+  @op(mongoLogId(1_001_000_034), ([ns, options]) => {
+    return { ns, maxTimeMS: options?.maxTimeMS };
+  })
   estimatedCount(
     ns: string,
     options: EstimatedDocumentCountOptions = {},
     executionOptions?: ExecutionOptions
   ): Promise<number> {
+    const maxTimeMS = options.maxTimeMS ?? 500;
     return this._cancellableOperation(
       async (session) => {
         return this._collection(ns, 'CRUD').estimatedDocumentCount({
           ...options,
+          maxTimeMS,
           session,
         });
       },
@@ -1725,8 +1729,12 @@ class DataServiceImpl extends WithLogContext implements DataService {
 
   // @ts-expect-error generic in the method trips up TS here resulting in
   // Promise<unknown> is not assignable to Promise<Document[]>
-  @op(mongoLogId(1_001_000_181), ([ns, pipeline]) => {
-    return { ns, stages: pipeline.map((stage) => Object.keys(stage)[0]) };
+  @op(mongoLogId(1_001_000_181), ([ns, pipeline, options]) => {
+    return {
+      ns,
+      stages: pipeline.map((stage) => Object.keys(stage)[0]),
+      maxTimeMS: options?.maxTimeMS,
+    };
   })
   aggregate<T = Document>(
     ns: string,
@@ -1750,7 +1758,9 @@ class DataServiceImpl extends WithLogContext implements DataService {
     );
   }
 
-  @op(mongoLogId(1_001_000_060))
+  @op(mongoLogId(1_001_000_060), ([ns, , options]) => {
+    return { ns, maxTimeMS: options?.maxTimeMS };
+  })
   find(
     ns: string,
     filter: Filter<Document>,