Add no-restricted-globals rule

Author: kraenhansen

package-lock.json

@@ -1,16 +1,33 @@
 'use strict';
+
+const globals = require('globals');
+
+const browserGlobals = Object.keys(globals.browser);
+const nodeGlobals = Object.keys(globals.node);
+const browserOnlyGlobals = browserGlobals.filter(
+  (key) => !nodeGlobals.includes(key)
+);
+
 module.exports = {
   root: true,
   extends: ['@mongodb-js/eslint-config-compass'],
   parserOptions: {
     tsconfigRootDir: __dirname,
-    project: ['./tsconfig-lint.json'],
+    project: ['./tsconfig.json'],
   },
   overrides: [
     {
       files: ['**/*.ts'],
       rules: {
         'no-console': 0,
+        'no-restricted-globals': ['error', ...browserOnlyGlobals],
+      },
+    },
+    {
+      // We need to access these in `browser.execute` calls
+      files: ['tests/**/*.ts', 'helpers/**/*.ts'],
+      rules: {
+        'no-restricted-globals': ['warn', ...browserOnlyGlobals],
       },
     },
   ],

packages/compass-e2e-tests/.eslintrc.js

@@ -55,6 +55,7 @@
     "electron-to-chromium": "^1.5.76",
     "eslint": "^7.25.0",
     "glob": "^10.2.5",
+    "globals": "^15.14.0",
     "hadron-build": "^25.6.1",
     "lodash": "^4.17.21",
     "mocha": "^10.2.0",