more tests

Author: paula-stacho

packages/compass-global-writes/src/components/index.spec.tsx

@@ -19,7 +19,7 @@ describe('Compass GlobalWrites Plugin', function () {
     await renderWithStore(
       <GlobalWrites shardingStatus={'SUBMITTING_FOR_SHARDING'} />
     );
-    expect(screen.getByTestId('unmanage-collection-button')).to.exist;
+    expect(screen.getByTestId('shard-collection-button')).to.exist;
   });
 
   it('renders plugin in SHARDING state', async function () {

packages/compass-global-writes/src/services/atlas-global-writes-service.ts

@@ -54,7 +54,7 @@ export type AutomationAgentDeploymentStatusApiResponse = {
   };
 };
 
-type AtlasShardKey = {
+export type AtlasShardKey = {
   _id: string;
   unique: boolean;
   key: Record<string, unknown>;

packages/compass-global-writes/src/store/index.spec.ts

@@ -7,9 +7,11 @@ import {
   unmanageNamespace,
   cancelSharding,
   POLLING_INTERVAL,
+  type ShardKey,
 } from './reducer';
 import sinon from 'sinon';
 import type {
+  AtlasShardKey,
   AutomationAgentDeploymentStatusApiResponse,
   AutomationAgentProcess,
   ClusterDetailsApiResponse,
@@ -74,14 +76,14 @@ function createStore({
   | {
       isNamespaceManaged?: () => boolean;
       hasShardingError?: () => boolean;
-      hasShardKey?: () => boolean;
+      hasShardKey?: () => boolean | AtlasShardKey;
       failsOnShardingRequest?: () => boolean;
       authenticatedFetchStub?: never;
     }
   | {
       isNamespaceManaged?: never;
       hasShardingError?: never;
-      hasShardKey?: () => boolean;
+      hasShardKey?: () => boolean | ShardKey;
       failsOnShardingRequest?: never;
       authenticatedFetchStub?: () => void;
     } = {}): GlobalWritesStore {
@@ -117,20 +119,24 @@ function createStore({
     }),
     automationAgentAwait: (_meta: unknown, type: string) => {
       if (type === 'getShardKey') {
+        const shardKey = hasShardKey();
         return {
-          response: hasShardKey()
-            ? [
-                {
-                  key: {
-                    location: 'range',
-                    secondary: shardKeyData.isCustomShardKeyHashed
-                      ? 'hashed'
-                      : 'range',
+          response:
+            shardKey === true
+              ? [
+                  {
+                    key: {
+                      location: 'range',
+                      secondary: shardKeyData.isCustomShardKeyHashed
+                        ? 'hashed'
+                        : 'range',
+                    },
+                    unique: true,
                   },
-                  unique: true,
-                },
-              ]
-            : [],
+                ]
+              : typeof shardKey === 'object'
+              ? [shardKey]
+              : [],
         };
       }
     },
@@ -340,6 +346,76 @@ describe('GlobalWritesStore Store', function () {
       expect(store.getState().status).to.equal('SHARD_KEY_CORRECT');
     });
 
+    context('invalid and mismatching shard keys', function () {
+      it('there is no location', async function () {
+        const store = createStore({
+          isNamespaceManaged: () => true,
+          hasShardKey: () => ({
+            _id: '123',
+            key: {
+              notLocation: 'range', // invalid
+              secondary: 'range',
+            },
+            unique: true,
+          }),
+        });
+        await waitFor(() => {
+          expect(store.getState().status).to.equal('SHARD_KEY_INVALID');
+        });
+      });
+
+      it('location is not a range', async function () {
+        const store = createStore({
+          isNamespaceManaged: () => true,
+          hasShardKey: () => ({
+            _id: '123',
+            key: {
+              location: 'hashed', // invalid
+              secondary: 'range',
+            },
+            unique: true,
+          }),
+        });
+        await waitFor(() => {
+          expect(store.getState().status).to.equal('SHARD_KEY_INVALID');
+        });
+      });
+
+      it('secondary key does not match', async function () {
+        const store = createStore({
+          isNamespaceManaged: () => true,
+          hasShardKey: () => ({
+            _id: '123',
+            key: {
+              location: 'range',
+              tertiary: 'range', // this is a different secondary key
+            },
+            unique: true,
+          }),
+        });
+        await waitFor(() => {
+          expect(store.getState().status).to.equal('SHARD_KEY_MISMATCH');
+        });
+      });
+
+      it('uniqueness does not match', async function () {
+        const store = createStore({
+          isNamespaceManaged: () => true,
+          hasShardKey: () => ({
+            _id: '123',
+            key: {
+              location: 'range',
+              secondary: 'range',
+            },
+            unique: false, // this does not match
+          }),
+        });
+        await waitFor(() => {
+          expect(store.getState().status).to.equal('SHARD_KEY_MISMATCH');
+        });
+      });
+    });
+
     it('sharding error', async function () {
       const store = createStore({
         isNamespaceManaged: () => true,