Skip to content

Commit 154575e

Browse files
committed
update tests
1 parent 9ae12db commit 154575e

File tree

3 files changed

+7
-11
lines changed

3 files changed

+7
-11
lines changed

packages/compass-e2e-tests/helpers/selectors.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -619,10 +619,6 @@ export const ShowMoreFieldsButton = '[data-testid="show-more-fields-button"]';
619619
export const OpenBulkUpdateButton = '[data-testid="crud-update"]';
620620
export const OpenBulkDeleteButton = '[data-testid="crud-bulk-delete"]';
621621
export const ErrorDetailsJson = '[data-testid="error-details-json"]';
622-
export const ErrorDetailsBackButton =
623-
'[data-testid="error-details-back-button"]';
624-
export const ErrorDetailsCloseButton =
625-
'[data-testid="error-details-close-button"]';
626622

627623
// Insert Document modal
628624

@@ -1325,11 +1321,11 @@ export const ConfirmationModalInput = `${ConfirmationModal} input`;
13251321

13261322
export const confirmationModalConfirmButton = (
13271323
modalSelector = ConfirmationModal
1328-
) => `${modalSelector} [role=dialog] button:nth-of-type(1)`;
1324+
) => `${modalSelector} [role=dialog] [data-testid*="confirm_button"]`;
13291325

13301326
export const confirmationModalCancelButton = (
13311327
modalSelector = ConfirmationModal
1332-
) => `${modalSelector} [role=dialog] button:nth-of-type(2)`;
1328+
) => `${modalSelector} [role=dialog] [data-testid*="cancel_button"]`;
13331329

13341330
// New pipeline from text modal
13351331
export const NewPipelineFromTextModal = '[data-testid="import-pipeline-modal"]';

packages/compass-e2e-tests/tests/collection-documents-tab.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -722,7 +722,7 @@ FindIterable<Document> result = collection.find(filter);`);
722722
await errorDetailsJson.waitForDisplayed();
723723

724724
// exit details
725-
await browser.clickVisible(Selectors.ErrorDetailsBackButton);
725+
await browser.clickVisible(Selectors.confirmationModalConfirmButton());
726726
await errorElement.waitForDisplayed();
727727
});
728728

@@ -771,7 +771,7 @@ FindIterable<Document> result = collection.find(filter);`);
771771
await errorDetailsJson.waitForDisplayed();
772772

773773
// exit details
774-
await browser.clickVisible(Selectors.ErrorDetailsCloseButton);
774+
await browser.clickVisible(Selectors.confirmationModalConfirmButton());
775775
await errorDetailsJson.waitForDisplayed({ reverse: true });
776776
});
777777

@@ -817,7 +817,7 @@ FindIterable<Document> result = collection.find(filter);`);
817817
await errorDetailsJson.waitForDisplayed();
818818

819819
// exit details
820-
await browser.clickVisible(Selectors.ErrorDetailsCloseButton);
820+
await browser.clickVisible(Selectors.confirmationModalConfirmButton());
821821
await errorDetailsJson.waitForDisplayed({ reverse: true });
822822
});
823823

@@ -860,7 +860,7 @@ FindIterable<Document> result = collection.find(filter);`);
860860
await errorDetailsJson.waitForDisplayed();
861861

862862
// exit details
863-
await browser.clickVisible(Selectors.ErrorDetailsCloseButton);
863+
await browser.clickVisible(Selectors.confirmationModalConfirmButton());
864864
await errorDetailsJson.waitForDisplayed({ reverse: true });
865865
});
866866
});

packages/compass-e2e-tests/tests/collection-import.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -574,7 +574,7 @@ describe('Collection import', function () {
574574
expect(await errorDetailsModal.getText()).to.include(
575575
'schemaRulesNotSatisfied'
576576
);
577-
await browser.clickVisible(Selectors.ErrorDetailsCloseButton);
577+
await browser.clickVisible(Selectors.confirmationModalConfirmButton());
578578
});
579579

580580
it('with CSV + abort on error unchecked, it includes the details in a file', async function () {

0 commit comments

Comments
 (0)