fix(@mongodb-js/compass-schema-validation): Pass full namespace to updateCollection instead of passing collMod option (#2426)

* fix(mongodb-data-service): Change merge order to restore pre-typescript method behavior

* fix(@mongodb-js/compass-schema-validation, mongodb-data-service): Pass full namespace to the updateCommand; Add comments explaining why the order of args is important

* chore(mongodb-data-service): One "explicitly" is more than enough

* chore: More typo fixes

Author: gribnoysup

packages/compass-schema-validation/src/modules/validation.js

@@ -471,9 +471,8 @@ export const saveValidation = (validation) => {
         'schema-validation-saved'
       );
       dataService.updateCollection(
-        namespace.database,
+        `${namespace.database}.${namespace.collection}`,
         {
-          collMod: namespace.collection,
           validator: savedValidation.validator,
           validationAction: savedValidation.validationAction,
           validationLevel: savedValidation.validationLevel

packages/data-service/src/native-client.ts

@@ -1102,14 +1102,19 @@ class NativeClient extends EventEmitter {
    */
   updateCollection(
     ns: string,
-    flags: Document,
+    // Collection name to update that will be passed to the collMod command will
+    // be derived from the provided namespace, this is why we are explicitly
+    // prohibiting to pass collMod flag here
+    flags: Document & { collMod?: never },
     callback: Callback<Document>
   ): void {
     const collectionName = this._collectionName(ns);
     const db = this.client.db(this._databaseName(ns));
+    // Order of arguments is important here, collMod is a command name and it
+    // should always be the first one in the object
     const command = {
-      ...flags,
       collMod: collectionName,
+      ...flags,
     };
     db.command(command, (error, result) => {
       if (error) {