Skip to content

Commit 17a8807

Browse files
committed
skip tests on linux
1 parent 796da35 commit 17a8807

File tree

1 file changed

+43
-38
lines changed

1 file changed

+43
-38
lines changed

packages/compass/src/main/menu.spec.ts

Lines changed: 43 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -654,44 +654,49 @@ describe('CompassMenu', function () {
654654
]);
655655
});
656656

657-
it('does not crash when rendering menu item with an accelerator', async () => {
658-
const menu = Menu.buildFromTemplate([
659-
{
660-
label: 'Test Super',
661-
accelerator: 'Super+Ctrl+T',
662-
},
663-
{
664-
label: 'Test Meta',
665-
accelerator: 'Meta+Ctrl+T',
666-
},
667-
{
668-
label: 'Test CmdOrCtrl',
669-
accelerator: 'CmdOrCtrl+Q',
670-
},
671-
{
672-
label: 'Test Command',
673-
accelerator: 'Command+H',
674-
},
675-
{
676-
label: 'Test Command+Shift',
677-
accelerator: 'Command+Shift+H',
678-
},
679-
{
680-
label: 'Test Atl+CmdOrCtrl',
681-
accelerator: 'Alt+CmdOrCtrl+S',
682-
},
683-
{
684-
label: 'Test Shift+CmdOrCtrl',
685-
accelerator: 'Shift+CmdOrCtrl+S',
686-
},
687-
]);
688-
const menuWillClose = once(menu, 'menu-will-close');
689-
menu.popup({
690-
window: new BrowserWindow({ show: false }),
691-
});
692-
menu.closePopup();
693-
await menuWillClose;
694-
});
657+
// TODO(COMPASS-8505): Remove skipping on linux
658+
const testIt = os.platform() === 'linux' ? it.skip : it;
659+
testIt(
660+
'does not crash when rendering menu item with an accelerator',
661+
async () => {
662+
const menu = Menu.buildFromTemplate([
663+
{
664+
label: 'Test Super',
665+
accelerator: 'Super+Ctrl+T',
666+
},
667+
{
668+
label: 'Test Meta',
669+
accelerator: 'Meta+Ctrl+T',
670+
},
671+
{
672+
label: 'Test CmdOrCtrl',
673+
accelerator: 'CmdOrCtrl+Q',
674+
},
675+
{
676+
label: 'Test Command',
677+
accelerator: 'Command+H',
678+
},
679+
{
680+
label: 'Test Command+Shift',
681+
accelerator: 'Command+Shift+H',
682+
},
683+
{
684+
label: 'Test Atl+CmdOrCtrl',
685+
accelerator: 'Alt+CmdOrCtrl+S',
686+
},
687+
{
688+
label: 'Test Shift+CmdOrCtrl',
689+
accelerator: 'Shift+CmdOrCtrl+S',
690+
},
691+
]);
692+
const menuWillClose = once(menu, 'menu-will-close');
693+
menu.popup({
694+
window: new BrowserWindow({ show: false }),
695+
});
696+
menu.closePopup();
697+
await menuWillClose;
698+
}
699+
);
695700

696701
it('should generate a menu template without collection submenu if `showCollection` is `false`', function () {
697702
expect(

0 commit comments

Comments
 (0)