Skip to content

Commit 19a368c

Browse files
committed
unify styles
1 parent 0b19805 commit 19a368c

File tree

7 files changed

+24
-71
lines changed

7 files changed

+24
-71
lines changed

packages/compass-global-writes/src/components/create-shard-key-form.tsx

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,7 @@ import {
2525
} from '../store/reducer';
2626
import { useAutocompleteFields } from '@mongodb-js/compass-field-store';
2727
import { connect } from 'react-redux';
28-
29-
const contentStyles = css({
30-
display: 'flex',
31-
flexDirection: 'column',
32-
gap: spacing[200],
33-
});
28+
import { containerStyles } from './common-styles';
3429

3530
const listStyles = css({
3631
listStyle: 'disc',
@@ -69,7 +64,7 @@ type ShardingAdvancedOption = 'default' | 'unique-index' | 'hashed-index';
6964

7065
function CreateShardKeyDescription() {
7166
return (
72-
<div className={contentStyles} data-testid="unsharded-text-description">
67+
<div className={containerStyles} data-testid="unsharded-text-description">
7368
<Subtitle>Configure compound shard key</Subtitle>
7469
<Body>
7570
To properly configure Global Writes, your collections must be sharded
@@ -165,7 +160,7 @@ export function CreateShardKeyForm({
165160
return (
166161
<>
167162
<CreateShardKeyDescription />
168-
<div className={contentStyles} data-testid="shard-collection-form">
163+
<div className={containerStyles} data-testid="shard-collection-form">
169164
<div className={shardKeyFormFieldsStyles}>
170165
<div>
171166
<Label htmlFor="first-shard-key">
@@ -277,7 +272,7 @@ export function CreateShardKeyForm({
277272
</Radio>
278273
</RadioGroup>
279274
{selectedAdvancedOption === 'hashed-index' && (
280-
<div className={cx(contentStyles, hasedIndexOptionsStyles)}>
275+
<div className={cx(containerStyles, hasedIndexOptionsStyles)}>
281276
<Checkbox
282277
data-testid="presplit-data-checkbox"
283278
onChange={() => setIsPreSplitData(!isPreSplitData)}

packages/compass-global-writes/src/components/states/shard-key-correct.tsx

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -24,28 +24,20 @@ import toNS from 'mongodb-ns';
2424
import { ShardZonesTable } from '../shard-zones-table';
2525
import { useConnectionInfo } from '@mongodb-js/compass-connections/provider';
2626
import ShardKeyMarkup from '../shard-key-markup';
27+
import {
28+
containerStyles,
29+
paragraphStyles,
30+
bannerStyles,
31+
} from '../common-styles';
2732

2833
const nbsp = '\u00a0';
2934

30-
const containerStyles = css({
31-
display: 'flex',
32-
flexDirection: 'column',
33-
gap: spacing[400],
34-
marginBottom: spacing[400],
35-
});
36-
3735
const codeBlockContainerStyles = css({
3836
display: 'flex',
3937
flexDirection: 'column',
4038
gap: spacing[100],
4139
});
4240

43-
const paragraphStyles = css({
44-
display: 'flex',
45-
flexDirection: 'column',
46-
gap: spacing[100],
47-
});
48-
4941
export type ShardKeyCorrectProps = {
5042
namespace: string;
5143
shardKey: ShardKey;
@@ -81,7 +73,7 @@ export function ShardKeyCorrect({
8173

8274
return (
8375
<div className={containerStyles}>
84-
<Banner variant={BannerVariant.Info}>
76+
<Banner variant={BannerVariant.Info} className={bannerStyles}>
8577
<strong>
8678
All documents in your collection should contain both the ‘location’
8779
field (with a ISO country or subdivision code) and your{' '}

packages/compass-global-writes/src/components/states/shard-key-invalid.tsx

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,7 @@ import React from 'react';
88
import ShardKeyMarkup from '../shard-key-markup';
99
import type { RootState, ShardKey } from '../../store/reducer';
1010
import { connect } from 'react-redux';
11-
12-
const containerStyles = css({
13-
display: 'flex',
14-
flexDirection: 'column',
15-
gap: spacing[400],
16-
marginBottom: spacing[400],
17-
});
11+
import { containerStyles, bannerStyles } from '../common-styles';
1812

1913
const paragraphStyles = css({
2014
display: 'flex',
@@ -30,7 +24,7 @@ export interface ShardKeyInvalidProps {
3024
export function ShardKeyInvalid({ shardKey, namespace }: ShardKeyInvalidProps) {
3125
return (
3226
<div className={containerStyles}>
33-
<Banner variant={BannerVariant.Danger}>
27+
<Banner variant={BannerVariant.Danger} className={bannerStyles}>
3428
<strong>
3529
To configure Global Writes, the first shard key of this collection
3630
must be &quot;location&quot; with ranged sharding and you must also

packages/compass-global-writes/src/components/states/shard-key-mismatch.tsx

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,7 @@ import {
1616
} from '../../store/reducer';
1717
import { connect } from 'react-redux';
1818
import type { ManagedNamespace } from '../../services/atlas-global-writes-service';
19-
20-
const containerStyles = css({
21-
display: 'flex',
22-
flexDirection: 'column',
23-
gap: spacing[400],
24-
marginBottom: spacing[400],
25-
});
19+
import { containerStyles, bannerStyles } from '../common-styles';
2620

2721
const unmanageBtnStyles = css({
2822
marginTop: spacing[100],
@@ -61,7 +55,7 @@ export function ShardKeyMismatch({
6155
}: ShardKeyMismatchProps) {
6256
return (
6357
<div className={containerStyles}>
64-
<Banner variant={BannerVariant.Danger}>
58+
<Banner variant={BannerVariant.Danger} className={bannerStyles}>
6559
<strong>
6660
Your requested shard key cannot be configured because the collection
6761
has already been sharded with a different key.

packages/compass-global-writes/src/components/states/sharding-error.tsx

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,7 @@ import {
1313
ShardingStatuses,
1414
} from '../../store/reducer';
1515
import CreateShardKeyForm from '../create-shard-key-form';
16-
17-
const containerStyles = css({
18-
display: 'flex',
19-
flexDirection: 'column',
20-
gap: spacing[400],
21-
});
16+
import { containerStyles, bannerStyles } from '../common-styles';
2217

2318
const btnStyles = css({
2419
float: 'right',
@@ -44,12 +39,10 @@ export function ShardingError({
4439
}: ShardingErrorProps) {
4540
return (
4641
<div className={containerStyles}>
47-
<Banner variant={BannerVariant.Warning}>
48-
<div>
49-
There was an error sharding your collection. Please cancel the
50-
request, make any necessary changes to your collection, and try again.
51-
<div className={errorStyles}>{shardingError}</div>
52-
</div>
42+
<Banner variant={BannerVariant.Warning} className={bannerStyles}>
43+
There was an error sharding your collection. Please cancel the request,
44+
make any necessary changes to your collection, and try again.
45+
<div className={errorStyles}>{shardingError}</div>
5346
<Button
5447
className={btnStyles}
5548
data-testid="cancel-sharding-btn"

packages/compass-global-writes/src/components/states/sharding.tsx

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,10 @@ import {
1414
type RootState,
1515
ShardingStatuses,
1616
} from '../../store/reducer';
17+
import { containerStyles, bannerStyles } from '../common-styles';
1718

1819
const nbsp = '\u00a0';
1920

20-
const containerStyles = css({
21-
display: 'flex',
22-
flexDirection: 'column',
23-
gap: spacing[400],
24-
});
25-
2621
const btnStyles = css({
2722
float: 'right',
2823
height: spacing[600],
@@ -39,7 +34,7 @@ export function ShardingState({
3934
}: ShardingStateProps) {
4035
return (
4136
<div className={containerStyles}>
42-
<Banner variant={BannerVariant.Info}>
37+
<Banner variant={BannerVariant.Info} className={bannerStyles}>
4338
<strong>Sharding your collection …</strong>
4439
{nbsp}this should not take too long.
4540
<Button

packages/compass-global-writes/src/components/states/unsharded.tsx

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,14 @@
11
import React from 'react';
2-
import {
3-
Banner,
4-
BannerVariant,
5-
css,
6-
spacing,
7-
} from '@mongodb-js/compass-components';
2+
import { Banner, BannerVariant } from '@mongodb-js/compass-components';
83
import CreateShardKeyForm from '../create-shard-key-form';
4+
import { containerStyles, bannerStyles } from '../common-styles';
95

106
const nbsp = '\u00a0';
117

12-
const containerStyles = css({
13-
display: 'flex',
14-
flexDirection: 'column',
15-
gap: spacing[400],
16-
});
17-
188
export function UnshardedState() {
199
return (
2010
<div className={containerStyles}>
21-
<Banner variant={BannerVariant.Warning}>
11+
<Banner variant={BannerVariant.Warning} className={bannerStyles}>
2212
<strong>
2313
To use Global Writes, this collection must be configured with a
2414
compound shard key made up of both a ‘location’ field and an

0 commit comments

Comments
 (0)