fix(compass-editors): fix nested field autocomplete COMPASS-6335 (#3874)

Author: Anemy

packages/compass-aggregations/README.md

@@ -49,8 +49,7 @@ If you're interested in helping with the Aggregation Builder plugin, we'd be ove
 - [`<ExportToLanguage />`](https://github.com/mongodb-js/compass-export-to-language) Modal plugin that connects `<Aggregation />` to `bson-transpilers` [for actual compiling to another language](https://github.com/mongodb-js/bson-transpilers)
 - [`mongodb-js/stage-validator`](https://github.com/mongodb-js/stage-validator) Aggregation Pipeline Stage grammar.
 - [`bson-transpilers`](https://github.com/mongodb-js/bson-transpilers) Read the amazing: [Compiler in JavaScript using ANTLR](https://medium.com/dailyjs/compiler-in-javascript-using-antlr-9ec53fd2780f)
-- [`mongodb-js/ace-mode`](https://github.com/mongodb-js/ace-mode) MongoDB highlighting rules for ACE.
-- [`mongodb-js/ace-autocompleter`](https://github.com/mongodb-js/ace-autocompleter) Makes ACE autocompletion aware of MongoDB Aggregation Pipeline [operators, expressions, and fields](https://github.com/mongodb-js/ace-autocompleter/tree/master/lib/constants).
+- [`@mongodb-js/compass-editor`](https://github.com/mongodb-js/compass/tree/main/packages/compass-editor) Reusable Compass editor component based on ace-editor with MongoDB-specific ace modes, themes, and autocompleters.
 
 ## Usage
 

packages/compass-editor/src/ace/query-autocompleter.test.ts

@@ -124,6 +124,113 @@ describe('QueryAutoCompleter', function () {
         });
       });
 
+      context('when the query prefix matches one of the fields', function () {
+        const { getCompletions } = setupQueryCompleter('{ pi', {
+          serverVersion: '3.4.0',
+          fields: [
+            {
+              name: 'pineapple',
+              value: 'pineapple',
+              score: 1,
+              meta: 'field',
+              version: '0.0.0',
+            },
+            {
+              name: 'noMatches',
+              value: 'noMatches',
+              score: 1,
+              meta: 'field',
+              version: '0.0.0',
+            },
+          ],
+        });
+
+        it('returns all the query operators', function () {
+          getCompletions((error, results) => {
+            expect(error).to.equal(null);
+            expect(results.length).to.equal(1);
+            expect(results).to.deep.equal([
+              {
+                name: 'pineapple',
+                value: 'pineapple',
+                score: 1,
+                meta: 'field',
+                version: '0.0.0',
+              },
+            ]);
+          });
+        });
+      });
+
+      context(
+        'when the query prefix has matching nested field names',
+        function () {
+          const { getCompletions } = setupQueryCompleter('{ pi', {
+            serverVersion: '3.4.0',
+            fields: [
+              {
+                name: 'pineapple',
+                value: 'pineapple',
+                score: 1,
+                meta: 'field',
+                version: '0.0.0',
+              },
+              {
+                name: 'pineapple.price',
+                value: '"pineapple.price"',
+                score: 1,
+                meta: 'field',
+                version: '0.0.0',
+              },
+              {
+                name: 'pineapple.fronds',
+                value: '"pineapple.fronds"',
+                score: 1,
+                meta: 'field',
+                version: '0.0.0',
+              },
+              {
+                name: 'noMatches',
+                value: 'noMatches',
+                score: 1,
+                meta: 'field',
+                version: '0.0.0',
+              },
+            ],
+          });
+
+          it('returns all the query operators', function () {
+            getCompletions((error, results) => {
+              expect(error).to.equal(null);
+              expect(results.length).to.equal(3);
+              expect(results).to.deep.equal([
+                {
+                  name: 'pineapple',
+                  value: 'pineapple',
+                  score: 1,
+                  meta: 'field',
+                  version: '0.0.0',
+                },
+                {
+                  name: 'pineapple.price',
+                  value: '"pineapple.price"',
+                  score: 1,
+                  meta: 'field',
+                  version: '0.0.0',
+                },
+                {
+                  name: 'pineapple.fronds',
+                  value: '"pineapple.fronds"',
+                  score: 1,
+                  meta: 'field',
+                  version: '0.0.0',
+                },
+              ]);
+            });
+          });
+        }
+      );
+
       context('when the version doesnt match a bson type', function () {
         const { getCompletions } = setupQueryCompleter('{ N', {
           serverVersion: '3.2.0',

packages/compass-editor/src/ace/util.ts

@@ -8,13 +8,14 @@ const filter = (
   prefix: string
 ) => {
   const parsedVersion = semver.parse(version);
+  const cleanVersion = parsedVersion
+    ? [parsedVersion.major, parsedVersion.minor, parsedVersion.patch].join('.')
+    : version;
   return entries.filter((e) => {
-    const cleanVersion = parsedVersion
-      ? [parsedVersion.major, parsedVersion.minor, parsedVersion.patch].join(
-          '.'
-        )
-      : version;
-    return e.value.startsWith(prefix) && semver.gte(cleanVersion, e.version);
+    if (!e.name) {
+      return false;
+    }
+    return e.name.startsWith(prefix) && semver.gte(cleanVersion, e.version);
   });
 };