Skip to content

Commit 1b26fab

Browse files
committed
chore: fix depcheck and var name
1 parent e244454 commit 1b26fab

File tree

5 files changed

+29
-6
lines changed

5 files changed

+29
-6
lines changed

package-lock.json

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/compass-e2e-tests/.depcheckrc

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,12 @@ ignores:
22
- '@mongodb-js/prettier-config-compass'
33
- '@mongodb-js/tsconfig-compass'
44
- '@wdio/types'
5-
- 'mongodb-compass'
65
- 'ps-list'
7-
- 'mongodb-runner'
6+
# Avoiding recursive deps on monorepo workspaces
7+
- 'mongodb-compass'
8+
- '@mongodb-js/mocha-config-compass'
9+
- 'compass-e2e-tests'
10+
- '@mongodb-js/compass-web'
811
# TODO(COMPASS-8312): depcheck doesn't count this dependency because it's a
912
# types only import and the depcheck parser is resolving the @types/<name>
1013
# package as a dep instead

packages/compass-e2e-tests/helpers/compass.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import crossSpawn from 'cross-spawn';
2626
import { CHROME_STARTUP_FLAGS } from './chrome-startup-flags';
2727
import {
2828
DEFAULT_CONNECTION_STRINGS,
29-
DEFAULT_CONNECTIONS_NAMES,
29+
DEFAULT_CONNECTION_NAMES,
3030
DEFAULT_CONNECTIONS_SERVER_INFO,
3131
ELECTRON_CHROMIUM_VERSION,
3232
TEST_COMPASS_WEB as _TEST_COMPASS_WEB,
@@ -80,12 +80,12 @@ export const MONGODB_TEST_SERVER_PORT = Number(
8080
export const DEFAULT_CONNECTION_STRING_1 = DEFAULT_CONNECTION_STRINGS[0];
8181
// NOTE: in browser.setupDefaultConnections() we don't give the first connection an
8282
// explicit name, so it gets a calculated one based off the connection string
83-
export const DEFAULT_CONNECTION_NAME_1 = DEFAULT_CONNECTIONS_NAMES[0];
83+
export const DEFAULT_CONNECTION_NAME_1 = DEFAULT_CONNECTION_NAMES[0];
8484

8585
// for testing multiple connections
8686
export const DEFAULT_CONNECTION_STRING_2 = DEFAULT_CONNECTION_STRINGS[1];
8787
// NOTE: in browser.setupDefaultConnections() the second connection gets given an explicit name
88-
export const DEFAULT_CONNECTION_NAME_2 = DEFAULT_CONNECTIONS_NAMES[2];
88+
export const DEFAULT_CONNECTION_NAME_2 = DEFAULT_CONNECTION_NAMES[1];
8989

9090
export const serverSatisfies = (
9191
semverCondition: string,

packages/compass-e2e-tests/helpers/test-runner-context.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ export const DEFAULT_CONNECTION_STRINGS = DEFAULT_CONNECTIONS.map((info) => {
6565
return info.connectionOptions.connectionString;
6666
});
6767

68-
export const DEFAULT_CONNECTIONS_NAMES = DEFAULT_CONNECTIONS.map((info) => {
68+
export const DEFAULT_CONNECTION_NAMES = DEFAULT_CONNECTIONS.map((info) => {
6969
return getConnectionTitle(info);
7070
});
7171

packages/compass-e2e-tests/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,15 @@
5050
"debug": "^4.3.4",
5151
"depcheck": "^1.4.1",
5252
"electron": "^30.5.1",
53+
"electron-to-chromium": "^1.5.41",
5354
"eslint": "^7.25.0",
5455
"fast-glob": "^3.2.7",
5556
"glob": "^10.2.5",
5657
"hadron-build": "^25.5.12",
5758
"lodash": "^4.17.21",
5859
"mocha": "^10.2.0",
5960
"mongodb": "^6.9.0",
61+
"mongodb-build-info": "^1.7.2",
6062
"mongodb-connection-string-url": "^3.0.1",
6163
"mongodb-log-writer": "^1.4.2",
6264
"mongodb-runner": "^5.6.3",

0 commit comments

Comments
 (0)