Skip to content

Commit 1d5a1aa

Browse files
committed
rewrite of query builder, 2-way data sync...
...with partial selection.
1 parent ced8bd3 commit 1d5a1aa

File tree

5 files changed

+275
-212
lines changed

5 files changed

+275
-212
lines changed

src/minicharts/index.js

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -18,20 +18,6 @@ module.exports = AmpersandView.extend(QueryBuilderMixin, {
1818
session: {
1919
subview: 'view',
2020
viewOptions: 'object',
21-
value: {
22-
type: 'object',
23-
default: null
24-
},
25-
upperRangeOperator: {
26-
type: 'string',
27-
default: '$lt',
28-
required: true
29-
},
30-
lowerRangeOperator: {
31-
type: 'string',
32-
default: '$gte',
33-
required: true
34-
},
3521
selectedValues: {
3622
type: 'array',
3723
default: function() {
@@ -49,7 +35,7 @@ module.exports = AmpersandView.extend(QueryBuilderMixin, {
4935
debounceRender: false,
5036
vizFn: vizFns[opts.model.getId().toLowerCase()] || null
5137
});
52-
this.listenTo(app.volatileQueryOptions, 'change:query', this.volatileQueryChanged);
38+
this.listenTo(app.volatileQueryOptions, 'change:query', this.handleVolatileQueryChange);
5339
},
5440
render: function() {
5541
this.renderWithTemplate(this);

src/minicharts/index.less

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
@mc-bg: @gray8;
1010
@mc-fg: @mc-blue0;
1111
@mc-fg-selected: @chart0;
12-
@mc-fg-halfselected: lighten(@chart0, 20%);
1312
@mc-fg-unselected: @gray6;
1413

1514
div.minichart.unique {

0 commit comments

Comments
 (0)