use default name for all relationships

Author: paula-stacho

packages/compass-data-modeling/src/components/drawer/collection-drawer-content.tsx

@@ -15,7 +15,6 @@ import {
   updateCollectionNote,
 } from '../../store/diagram';
 import type { DataModelingState } from '../../store/reducer';
-import { getDefaultRelationshipName } from '../../utils';
 import {
   DMDrawerSection,
   DMFormFieldContainer,
@@ -141,7 +140,6 @@ const CollectionDrawerContent: React.FunctionComponent<
       <RelationshipsSection
         relationships={relationships}
         emptyMessage="This collection does not have any relationships yet."
-        getRelationshipLabel={getDefaultRelationshipName}
         onCreateNewRelationshipClick={() => {
           onCreateNewRelationshipClick({ localNamespace: namespace });
         }}

packages/compass-data-modeling/src/components/drawer/diagram-editor-side-panel.spec.tsx

@@ -350,7 +350,7 @@ describe('DiagramEditorSidePanel', function () {
 
       // Open relationshipt editing form
       const relationshipItem = screen
-        .getByText('airports.Country')
+        .getByText('countries.name → airports.Country')
         .closest('li');
       expect(relationshipItem).to.be.visible;
       userEvent.click(
@@ -374,7 +374,7 @@ describe('DiagramEditorSidePanel', function () {
 
       // Find the relationhip item
       const relationshipItem = screen
-        .getByText('airports.Country')
+        .getByText('countries.name → airports.Country')
         .closest('li');
       expect(relationshipItem).to.be.visible;
 

packages/compass-data-modeling/src/components/drawer/field-drawer-content.tsx

@@ -164,18 +164,6 @@ const FieldDrawerContent: React.FunctionComponent<FieldDrawerContentProps> = ({
       <RelationshipsSection
         relationships={relationships}
         emptyMessage="This field does not have any relationships yet."
-        getRelationshipLabel={([local, foreign]) => {
-          const labelField =
-            local.ns === namespace &&
-            local.fields &&
-            areFieldPathsEqual(local.fields, fieldPath)
-              ? foreign
-              : local;
-          return [
-            labelField.ns ? toNS(labelField.ns).collection : '',
-            labelField.fields?.join('.'),
-          ].join('.');
-        }}
         onCreateNewRelationshipClick={() => {
           onCreateNewRelationshipClick({
             localNamespace: namespace,

packages/compass-data-modeling/src/components/drawer/relationships-section.tsx

@@ -10,6 +10,7 @@ import {
   spacing,
 } from '@mongodb-js/compass-components';
 import type { Relationship } from '../../services/data-model-storage';
+import { getDefaultRelationshipName } from '../../utils';
 
 const titleBtnStyles = css({
   marginLeft: 'auto',
@@ -47,7 +48,6 @@ const relationshipContentStyles = css({
 type RelationshipsSectionProps = {
   relationships: Relationship[];
   emptyMessage: string;
-  getRelationshipLabel: (relationship: Relationship['relationship']) => string;
   onCreateNewRelationshipClick: () => void;
   onEditRelationshipClick: (rId: string) => void;
   onDeleteRelationshipClick: (rId: string) => void;
@@ -58,7 +58,6 @@ export const RelationshipsSection: React.FunctionComponent<
 > = ({
   relationships,
   emptyMessage,
-  getRelationshipLabel,
   onCreateNewRelationshipClick,
   onEditRelationshipClick,
   onDeleteRelationshipClick,
@@ -85,7 +84,9 @@ export const RelationshipsSection: React.FunctionComponent<
         ) : (
           <ul className={relationshipsListStyles}>
             {relationships.map((r) => {
-              const relationshipLabel = getRelationshipLabel(r.relationship);
+              const relationshipLabel = getDefaultRelationshipName(
+                r.relationship
+              );
 
               return (
                 <li