feat: Made early indexes variables update when changed CLOUDP-317478 (#6901)

* made early indexes variables update when changed

* added comments

Author: rubydong

packages/compass-preferences-model/src/compass-web-preferences-access.ts

@@ -6,8 +6,12 @@ import { InMemoryStorage } from './preferences-in-memory-storage';
 import { getActiveUser } from './utils';
 
 const editablePreferences: (keyof UserPreferences)[] = [
+  // Value can change from false to true during allocation / checking
   'optInDataExplorerGenAIFeatures',
   'cloudFeatureRolloutAccess',
+  // TODO(COMPASS-9353): Provide a standard for updating Compass preferences in web
+  'enableIndexesGuidanceExp',
+  'showIndexesGuidanceVariant',
 
   // Exposed for testing purposes.
   'enableGenAISampleDocumentPassingOnAtlasProject',
@@ -27,9 +31,9 @@ export class CompassWebPreferencesAccess implements PreferencesAccess {
   savePreferences(_attributes: Partial<UserPreferences>) {
     // Only allow runtime updating certain preferences.
     if (
-      Object.keys(_attributes).length === 1 &&
-      editablePreferences.includes(
-        Object.keys(_attributes)[0] as keyof UserPreferences
+      Object.keys(_attributes).length >= 1 &&
+      Object.keys(_attributes).every((attribute) =>
+        editablePreferences.includes(attribute as keyof UserPreferences)
       )
     ) {
       return Promise.resolve(this._preferences.savePreferences(_attributes));

packages/compass-web/src/entrypoint.tsx

@@ -273,9 +273,7 @@ const CompassWeb = ({
     onLog,
     onDebug,
   });
-
   const preferencesAccess = useCompassWebPreferences(initialPreferences);
-
   const initialWorkspaceRef = useRef(initialWorkspace);
   const initialWorkspaceTabsRef = useRef(
     initialWorkspaceRef.current ? [initialWorkspaceRef.current] : []
@@ -296,6 +294,23 @@ const CompassWeb = ({
     preferences: preferencesAccess.current,
   });
 
+  useEffect(() => {
+    // TODO(COMPASS-9353): Provide a standard way of updating Compass' preferences from web.
+    // Avoid duplicating this pattern until we address this ticket.
+    const updateEarlyIndexesPreferences = async () => {
+      await preferencesAccess.current.savePreferences({
+        enableIndexesGuidanceExp: initialPreferences?.enableIndexesGuidanceExp,
+        showIndexesGuidanceVariant:
+          initialPreferences?.showIndexesGuidanceVariant,
+      });
+    };
+    void updateEarlyIndexesPreferences();
+  }, [
+    initialPreferences?.enableIndexesGuidanceExp,
+    initialPreferences?.showIndexesGuidanceVariant,
+    preferencesAccess,
+  ]);
+
   return (
     <GlobalAppRegistryProvider value={appRegistry.current}>
       <AppRegistryProvider scopeName="Compass Web Root">