fix: clear the errors in the insert document modal when there are no errors COMPASS-3246 (#7157)

* clear the errors in the insert document modal when there are no errors

* Update packages/compass-crud/src/components/insert-document-dialog.tsx

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Copilot <[email protected]>

Author: lerouxb

packages/compass-crud/src/components/insert-document-dialog.tsx

@@ -194,6 +194,8 @@ const InsertDocumentDialog: React.FC<InsertDocumentDialogProps> = ({
         setInvalidElements((invalidElements) =>
           without(invalidElements, el.uuid)
         );
+      } else {
+        setInvalidElements([]);
       }
     },
     [hasErrors, setInvalidElements]

packages/compass-e2e-tests/helpers/selectors.ts

@@ -730,6 +730,8 @@ export const HadronDocumentClickableKey =
   '[data-testid="hadron-document-clickable-key"]';
 export const HadronDocumentKeyEditor =
   '[data-testid="hadron-document-key-editor"]';
+export const HadronDocumentTypeEditor =
+  '[data-testid="hadron-document-type-editor"]';
 export const HadronDocumentValue =
   '[data-testid="hadron-document-element-value"]';
 export const HadronDocumentValueEditor =

packages/compass-e2e-tests/tests/collection-import.test.ts

@@ -241,6 +241,20 @@ describe('Collection import', function () {
       `${Selectors.InsertDialog} ${Selectors.HadronDocumentAddSibling}`
     );
 
+    // set the type to Date (this causes an error)
+    await browser
+      .$(
+        `${Selectors.InsertDialog} ${Selectors.HadronDocumentElement}:last-child ${Selectors.HadronDocumentTypeEditor}`
+      )
+      .selectByAttribute('value', 'Date');
+
+    // set the type to String (this clears the error)
+    await browser
+      .$(
+        `${Selectors.InsertDialog} ${Selectors.HadronDocumentElement}:last-child ${Selectors.HadronDocumentTypeEditor}`
+      )
+      .selectByAttribute('value', 'String');
+
     // Add field data
     await browser.setValueVisible(
       `${Selectors.InsertDialog} ${Selectors.HadronDocumentElement}:last-child ${Selectors.HadronDocumentKeyEditor}`,