chore: use @mongosh-js/[email protected], ignore eqeqeq and noconsole errors (#4629)

use @mongosh-js/[email protected], ignore eqeqeq and noconsole errors

Author: lerouxb

configs/eslint-config-compass/package.json

@@ -15,7 +15,7 @@
   "dependencies": {
     "@babel/core": "^7.21.4",
     "@babel/eslint-parser": "^7.14.3",
-    "@mongodb-js/eslint-config-devtools": "^0.9.4",
+    "@mongodb-js/eslint-config-devtools": "^0.9.7",
     "@mongodb-js/eslint-plugin-compass": "^1.0.6",
     "@typescript-eslint/eslint-plugin": "^5.59.0",
     "@typescript-eslint/parser": "^5.59.0",

package-lock.json

@@ -76,6 +76,7 @@ export function assertStageNode(
   } else if (
     node.properties.length !== 1 ||
     node.properties[0].type !== 'ObjectProperty' ||
+    // eslint-disable-next-line eqeqeq
     node.properties[0].key == null
   ) {
     error =
@@ -87,6 +88,7 @@ export function assertStageNode(
     error = `Unrecognized pipeline stage name${key ? `: '${key}'` : ''}`;
     errorCode = StageAssertionErrorCodes.UnrecognizedStageName;
     causedBy = node.properties[0].key;
+    // eslint-disable-next-line eqeqeq
   } else if (!loose && node.properties[0].value == null) {
     error = 'Stage value can not be empty';
     errorCode = StageAssertionErrorCodes.NoStageValue;

packages/compass-aggregations/src/modules/pipeline-builder/pipeline-parser/stage-parser.ts

@@ -4,6 +4,7 @@ let electronApp;
 try {
   electronApp = require('@electron/remote').app;
 } catch (e) {
+  // eslint-disable-next-line no-console
   console.log('Could not load @electron/remote', e.message);
 }
 

packages/compass-aggregations/src/utils/get-directory.js

@@ -1,3 +1,4 @@
+/* eslint-disable filename-rules/match */
 import React, {
   useCallback,
   useEffect,
@@ -50,16 +51,18 @@ import {
   labelDescriptionContainerStyle,
   multiselectInputElementStyle,
 } from './Combobox.styles';
+import type {
+  ComboboxProps,
+  onChangeType,
+  OptionObject,
+  SelectValueType,
+} from './Combobox.types';
 import {
   ComboboxElement,
-  ComboboxProps,
   ComboboxSize,
   getNullSelection,
-  onChangeType,
-  OptionObject,
   Overflow,
   SearchState,
-  SelectValueType,
   State,
   TruncationLocation,
 } from './Combobox.types';
@@ -189,7 +192,7 @@ export function Combobox<M extends boolean>({
    */
   const isMultiselect = useCallback(
     <T extends string>(val?: Array<T> | T | null): val is Array<T> => {
-      if (multiselect && (typeof val == 'string' || typeof val == 'number')) {
+      if (multiselect && (typeof val === 'string' || typeof val === 'number')) {
         consoleOnce.error(
           `Error in Combobox: multiselect is set to \`true\`, but received a ${typeof val} value: "${val}"`
         );
@@ -245,9 +248,7 @@ export function Combobox<M extends boolean>({
           }
         }
         setSelection(newSelection as SelectValueType<M>);
-        (onChange as onChangeType<true>)?.(
-          newSelection as SelectValueType<true>
-        );
+        (onChange as onChangeType<true>)?.(newSelection);
       } else {
         const newSelection: SelectValueType<M> = value as SelectValueType<M>;
         setSelection(newSelection);
@@ -901,7 +902,7 @@ export function Combobox<M extends boolean>({
           initialValue.filter((value) => isValueValid(value)) ?? [];
         setSelection(filteredValue as SelectValueType<M>);
       } else {
-        if (isValueValid(initialValue as string)) {
+        if (isValueValid(initialValue)) {
           setSelection(initialValue);
         }
       }
@@ -1366,7 +1367,7 @@ export function Combobox<M extends boolean>({
 
   /**
    * Scrolls the combobox to the far right.
-   * Used when `overflow == 'scroll-x'`.
+   * Used when `overflow === 'scroll-x'`.
    * Has no effect otherwise
    */
   function scrollInputToEnd() {

packages/compass-components/src/components/combobox/Combobox.tsx

@@ -1,6 +1,7 @@
-import { ReactElement, ReactNode } from 'react';
+/* eslint-disable filename-rules/match */
 
-import { Either, HTMLElementProps } from '@leafygreen-ui/lib';
+import type { ReactElement, ReactNode } from 'react';
+import type { Either, HTMLElementProps } from '@leafygreen-ui/lib';
 
 /**
  * Prop Enums & Types

packages/compass-components/src/components/combobox/Combobox.types.ts

@@ -1,3 +1,4 @@
+/* eslint-disable filename-rules/match */
 import React, { useCallback, useContext, useMemo } from 'react';
 import PropTypes from 'prop-types';
 
@@ -10,11 +11,11 @@ import { palette } from '@leafygreen-ui/palette';
 import { fontFamilies, spacing, typeScales } from '@leafygreen-ui/tokens';
 
 import { menuItemHeight, menuItemPadding } from './ComboboxMenu/Menu.styles';
-import {
+import type {
   ComboboxOptionProps,
-  ComboboxSize as Size,
   InternalComboboxOptionProps,
 } from './Combobox.types';
+import { ComboboxSize as Size } from './Combobox.types';
 import { ComboboxContext } from './ComboboxContext';
 import { wrapJSX } from './utils';
 
@@ -227,6 +228,7 @@ const InternalComboboxOption = React.forwardRef<
         if (isComponentGlyph(glyph)) {
           return glyph;
         }
+        // eslint-disable-next-line no-console
         console.error(
           '`ComboboxOption` instance did not render icon because it is not a known glyph element.',
           glyph
@@ -335,6 +337,7 @@ const InternalComboboxOption = React.forwardRef<
 InternalComboboxOption.displayName = 'ComboboxOption';
 
 export { InternalComboboxOption };
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 export function ComboboxOption(_: ComboboxOptionProps): JSX.Element {
   throw Error('`ComboboxOption` must be a child of a `Combobox` instance');
 }

packages/compass-components/src/components/combobox/ComboboxOption.tsx

@@ -63,6 +63,7 @@ export class GuideCueService extends EventTarget {
     }
     const cueIndex = this.getCueIndex(cue.cueId, cue.groupId);
     if (cueIndex !== -1) {
+      // eslint-disable-next-line no-console
       console.warn(`The Cue ${cue.cueId} is already added.`);
       return;
     }

packages/compass-components/src/components/guide-cue/guide-cue-service.ts

@@ -76,6 +76,7 @@ export function useOpenModalThroughIpc(
     ipc_ ??= require('hadron-ipc').ipcRenderer;
   } catch (err) {
     ipc_ ??= {};
+    // eslint-disable-next-line no-console
     console.warn('could not load hadron-ipc', err);
   }
   const ipc = ipcForTesting ?? ipc_;

packages/compass-connection-import-export/src/hooks/common.ts

@@ -5,4 +5,12 @@ module.exports = {
     tsconfigRootDir: __dirname,
     project: ['./tsconfig-lint.json'],
   },
+  overrides: [
+    {
+      files: ['**/*.ts'],
+      rules: {
+        'no-console': 0,
+      },
+    },
+  ],
 };